diff mbox

[dpdk-dev] qede: add missing external dependency and disable by default

Message ID c610f841ac50a2dbd7417f8f1bcc5d27260b62c9.1464085711.git.pmatilai@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Panu Matilainen May 24, 2016, 10:28 a.m. UTC 
  The qede driver depends on libz but the LDLIBS entry in makefile
was missing. Also because of the external dependency, make it
disabled in default config as per common DPDK policy on external deps.

Fixes: ec94dbc57362 ("qede: add base driver")

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 config/common_base        | 2 +-
 drivers/net/qede/Makefile | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon May 24, 2016, 2:15 p.m. UTC | #1 
2016-05-24 13:28, Panu Matilainen:
> The qede driver depends on libz but the LDLIBS entry in makefile
> was missing. Also because of the external dependency, make it
> disabled in default config as per common DPDK policy on external deps.
> 
> Fixes: ec94dbc57362 ("qede: add base driver")
> 
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/config/common_base b/config/common_base
index 3535c6e..47c26f6 100644
--- a/config/common_base
+++ b/config/common_base
@@ -299,7 +299,7 @@  CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n
 
 # QLogic 25G/40G PMD
 #
-CONFIG_RTE_LIBRTE_QEDE_PMD=y
+CONFIG_RTE_LIBRTE_QEDE_PMD=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRV=n
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index 4cc9ee8..c9b3b1c 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -14,6 +14,8 @@  LIB = librte_pmd_qede.a
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 
+LDLIBS += -lz
+
 EXPORT_MAP := rte_pmd_qede_version.map
 
 LIBABIVER := 1