From patchwork Mon Apr 23 11:09:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 38685 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BC181C0B; Mon, 23 Apr 2018 13:08:49 +0200 (CEST) Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id E3B7BF3E for ; Mon, 23 Apr 2018 13:08:47 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id v60-v6so40054678wrc.7 for ; Mon, 23 Apr 2018 04:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=NPIJ7UMIEJqcL/K5WKMZBwECtckolem7ix2NK1xdM28=; b=wF+4MyhzqT6+y9GCBAk9iwlr2GrJ9Cm5F8/taojCCi9mJ9v/Bms0T3y0dVxI5NWfVd I8gwahmNnjKkhwVqGOVRw2Cex5vHlkYg+ZcOmajFxGFTjSZqkJzXSfSaJKCqehIVJXqF 8vctTE2hpOIyKv0rWPS/j8Ng7DW4E9yuGhurbRMSP8MIUw6pQjmjWpMF7A684ZUqE7AN Mk8l/iEfaLt+8mweSFhEbnAi+aty3fFc7hmT7UOED8cWVj3PdoMDQ/Zy/J9wRJwYZMmT mzvj4a4PEJvUeH9fjW9/HKQl0LPIbrcfUgcYt+/ZTY0EMYAf3rQpWw3NYH8CsvrAOUIY Jysg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=NPIJ7UMIEJqcL/K5WKMZBwECtckolem7ix2NK1xdM28=; b=Hn4PMjv62+wemeTAMapIhKAcJkhHmXdrPoZ3cR+jKF1n1ZcVw6WA2HWD04KZqrk8FY e0HiYE6TsbhrFqIqpl5NEZSqJS2pG1mdGllCJZBdNlRi6PkFcfkuPpC1CTJoRH41zjvr pbETBx69pBt1KO0SYCB4qTsf/iUCtuTDCsSZbE2s1cyLIbjKUFVBeSRxUbY/DJTaxQav RJiQb4YJfeyGsIlc6lHQhS7rtttI19gePxMblCQnziTT5Him0Zojiufhs3CQDDCHHfrK 99mXBI6iQIbOgSFYJgGuBmBuWojtnvdZ+GPRKvXc9RyTXZaXUggTYNgcvbiB40ePlLAh Jafw== X-Gm-Message-State: ALQs6tAId3xhvb+gecIi+qokXcSoAS0KgXiYRmT3mYFqeY57wtAiyRL5 dd0zzw4EfQdVx1/5DQ3Wd/kXpOjdyA== X-Google-Smtp-Source: AIpwx49/AbMjlA0GoGZb5wg54oiIFtClpTb3PwkJG6DSf1r6fpZnZZlj5WLirjzjRF5zm+J5f9zXGQ== X-Received: by 10.28.182.70 with SMTP id g67mr9457149wmf.88.1524481726815; Mon, 23 Apr 2018 04:08:46 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n49-v6sm18642512wrn.50.2018.04.23.04.08.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Apr 2018 04:08:45 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org, Yongseok Koh Cc: Adrien Mazarguil Date: Mon, 23 Apr 2018 13:09:26 +0200 Message-Id: X-Mailer: git-send-email 2.17.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v3 1/3] net/mlx5: more checks on MAC addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Verify MAC address before further process. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_mac.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c index edc7a32ae..f24b5f759 100644 --- a/drivers/net/mlx5/mlx5_mac.c +++ b/drivers/net/mlx5/mlx5_mac.c @@ -71,7 +71,10 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index) const int vf = priv->config.vf; int ret; - assert(index < MLX5_MAX_MAC_ADDRESSES); + if (index >= MLX5_MAX_MAC_ADDRESSES) + return; + if (is_zero_ether_addr(&dev->data->mac_addrs[index])) + return; if (vf) mlx5_nl_mac_addr_remove(dev, &dev->data->mac_addrs[index], index); @@ -107,7 +110,14 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac, const int vf = priv->config.vf; unsigned int i; - assert(index < MLX5_MAX_MAC_ADDRESSES); + if (index >= MLX5_MAX_MAC_ADDRESSES) { + rte_errno = EINVAL; + return -rte_errno; + } + if (is_zero_ether_addr(mac)) { + rte_errno = EINVAL; + return -rte_errno; + } /* First, make sure this address isn't already configured. */ for (i = 0; (i != MLX5_MAX_MAC_ADDRESSES); ++i) { /* Skip this index, it's going to be reconfigured. */