From patchwork Wed Aug 23 08:15:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 27745 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D88587D7B; Wed, 23 Aug 2017 10:15:45 +0200 (CEST) Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 879D87D5A for ; Wed, 23 Aug 2017 10:15:38 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id r187so9952738wma.0 for ; Wed, 23 Aug 2017 01:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=puWvFJRyuOusX2aXdN2bCHNEGZqrOEd8UzDX8HUm6Ks=; b=brYMohjKYPRNrzuJrkt8DfdwZJMNcNHrbsSM1K8YjkqPL1q3EeYKVo2JJVyKblq/Hw 2nhSntabDfSLrDPbRDsQwR9DKsrKbKTwGPl9+vdTIIuanhSoZ5HmUU69MmOPPuWxMycC qrl79FY04bYj5l81uFQmRRS5PQ+DuJsJ5nG+PPWwhVminmjUTF3ADe2b6pGOoklTmWk3 tBqSJVi0Dnjaa5gjnTfPzSSODoheRCBca/9tuFjBBxJLs5L6aUVSj0kQtxr0aCluM/tg cERVfR6VX1eZ4DwuuQk9eg1gHgGRVtIZjFY6kyvpdHqTmr/QW5wH4P2OdSdvGKZ+G0/Q AoDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=puWvFJRyuOusX2aXdN2bCHNEGZqrOEd8UzDX8HUm6Ks=; b=XXsSvQKvm/4VPkMzWTDfiCRcyatl2ZSLKhZdJzBq6+DJMdk/rP+8zcRkeAmXCqWIN0 sxPdHvmBrZ5fgT2hREro1XIqJU4T+GIk2Jvka0nUQ06PBEjFZ1pwV+yTQkfSBPVMthL3 2HiQBdDl6h65GOSV9W6Twg9+FFGMJ0zm8WELRPtwME07i1ys81AAcWUdyKqGLMhT3N55 +ChvaFkBfIGAPSaCCM1KCb/XHF/ZsqJ6+BCr3r+zxJvxevlLGzNo0SmGudCl8unjh4hY G+Q+QyH6xkkEpBkrpNV62FoT0QmmpM14x3dDJbaES5E89fooSBkGwdV6fVsualjS8fyi nOuw== X-Gm-Message-State: AHYfb5j/cQILPlIVveRDCW4Yv4quy9veNvuF3eHY1tggI3D2kwhgo5nK Armhn3Adx3vGs4ASDPKSYg== X-Received: by 10.28.212.147 with SMTP id l141mr1142067wmg.7.1503476137821; Wed, 23 Aug 2017 01:15:37 -0700 (PDT) Received: from ping.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c19sm508450wre.43.2017.08.23.01.15.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Aug 2017 01:15:37 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org, Ferruh Yigit Cc: Shahaf Shuler Date: Wed, 23 Aug 2017 10:15:08 +0200 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 4/8] net/mlx5: remove flow drop useless if branches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Those two if statements are useless as there is a verification on the drop field of the flow to jump to the end of the function just above. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 86be929..d62ccff 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1279,10 +1279,6 @@ priv_flow_destroy(struct priv *priv, claim_zero(ibv_destroy_qp(flow->qp)); if (flow->ind_table) claim_zero(ibv_exp_destroy_rwq_ind_table(flow->ind_table)); - if (flow->drop && flow->wq) - claim_zero(ibv_exp_destroy_wq(flow->wq)); - if (flow->drop && flow->cq) - claim_zero(ibv_destroy_cq(flow->cq)); if (flow->mark) { struct rte_flow *tmp; struct rxq *rxq;