diff mbox series

net/mlx5: fix missing release of Rx queue object

Message ID b98eba61a8867dbbdc2d427e826ec44b11cdbf42.1557214064.git.dekelp@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Shahaf Shuler
Headers
Series net/mlx5: fix missing release of Rx queue object |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Dekel Peled May 7, 2019, 7:26 a.m. UTC 
  Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs
some actions on the returned rxq_ibv.
It doens't release the rxq_ibv when all is completed with success.

This patch adds call to mlx5_rxq_ibv_release() where it's missing.

Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue objects")
Cc: stable@dpdk.org

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxq.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Shahaf Shuler May 8, 2019, 4:44 a.m. UTC | #1 
Tuesday, May 7, 2019 10:26 AM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue
> object
> 
> Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs some
> actions on the returned rxq_ibv.
> It doens't release the rxq_ibv when all is completed with success.
> 
> This patch adds call to mlx5_rxq_ibv_release() where it's missing.
> 
> Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue
> objects")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>

Applied to next-net-mlx, thanks.
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 0a4c02e..099c9e0 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -730,6 +730,7 @@ 
 	}
 	rxq_data->cq_arm_sn++;
 	mlx5_glue->ack_cq_events(rxq_ibv->cq, 1);
+	mlx5_rxq_ibv_release(rxq_ibv);
 	return 0;
 exit:
 	ret = rte_errno; /* Save rte_errno before cleanup. */