From patchwork Wed Mar 29 07:32:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 22669 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D9FA74A63; Wed, 29 Mar 2017 09:38:23 +0200 (CEST) Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 7CA091396 for ; Wed, 29 Mar 2017 09:32:31 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id w43so4653668wrb.0 for ; Wed, 29 Mar 2017 00:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Xnagvk4f+0z/MoNcc9R3ynkR4yukVfrifXKp8GLsBOc=; b=Ko4TFs4pMatfP+QPern7l4L4Rs60cZ4s8BDrCcQBfUnrfTEEaNHThJGLLvUasLt+U1 l2mA71Xui1m4E4bwiJWojnKW8L+jLP+UpXTbzf+cUHR650lBpnBWQqtOY16gDfJVgUkh jOnTgr1Ow0JC6+KaJlAm6opd0Q+dXqmenDq1wK7BXuJFasZArZYkkPTwlsph5PzIjjJa kzy+nn3IO7O24vtHKODbQ2fKaA77n0WlsorKSTID4Wng5ua1wuDa5FjwdxfbKQL/ryti nLbFCpOgSFs4EA4xRMmbcQ5pzSql4fMY/ndOrRNv1iSLJ9XWkaSwQfsls0oJzGs9nyg4 7iTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Xnagvk4f+0z/MoNcc9R3ynkR4yukVfrifXKp8GLsBOc=; b=J4anzZGiZ8Ng7wrDD+ANo25yq1soir5HIDkYemKsQ9uICpLDCiOWQ1XEOI3ZESJJ5r dfdRB1gVf/Kg8/RZokw81uzA5dmX+CPxFzD3NLEiDHjJ1wfUy82nq4l18xiyvzYZGsBt cSrVibeiq60N5Ds9WFTnCamkswHYKpuRIuVpRWbEkDyVzQ6SoxouUOvEUxUA1ccIwEGG frUIn4vwRFqYgiRBCnNDnG/mKwD+gmYvObqBeJQp4fyrKZ2WqmP+/PMI3NfCKrSRlNhI jprM8y6fR73BKP1bAnkZies6nNacFMqS47Dh07kByxIG+c5M5WsNUNiupo5WbkZrkQIz lmxg== X-Gm-Message-State: AFeK/H3yOLPwitXnRW/1v4ZXpIbJqVbySnGFr99xbdGz0UcQ6rg7XbsBj40gmFJPz51heGEe X-Received: by 10.223.176.175 with SMTP id i44mr29896616wra.96.1490772751241; Wed, 29 Mar 2017 00:32:31 -0700 (PDT) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id t68sm2638992wrc.55.2017.03.29.00.32.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 29 Mar 2017 00:32:30 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil , Yongseok Koh , stable@dpdk.org Date: Wed, 29 Mar 2017 09:32:10 +0200 Message-Id: X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH] net/mlx5: fix Tx when first segment size is too short X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" First segment size must be 18 bytes, packets not respecting this are silently not sent by the NIC but counted as sent by the PMD. The only way to figure out is compiling the PMD in debug mode. Cc: stable@dpdk.org Fixes: 6579c27c11a5 ("net/mlx5: remove gather loop on segments") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 823aac8..e2e8a22 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -485,7 +485,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) #ifdef MLX5_PMD_SOFT_COUNTERS total_length = length; #endif - assert(length >= MLX5_WQE_DWORD_SIZE); + if (length < (MLX5_WQE_DWORD_SIZE + 2)) + break; /* Update element. */ (*txq->elts)[elts_head] = buf; elts_head = (elts_head + 1) & (elts_n - 1);