diff mbox

[dpdk-dev] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve()

Message ID b2c9de21812b030103d11d6cf62ba7895441885d.1447832032.git.pmatilai@redhat.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Panu Matilainen Nov. 18, 2015, 7:33 a.m. UTC 
  Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 lib/librte_ether/rte_ether_version.map | 1 +
 1 file changed, 1 insertion(+)

Comments

John McNamara Nov. 18, 2015, 11:48 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
> Sent: Wednesday, November 18, 2015 7:34 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
> rte_eth_dma_zone_reserve()
> 
> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
> 
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

Out of curiosity, how did you identify this issue?
Panu Matilainen Nov. 18, 2015, 12:16 p.m. UTC | #2 
On 11/18/2015 01:48 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
>> Sent: Wednesday, November 18, 2015 7:34 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
>> rte_eth_dma_zone_reserve()
>>
>> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
>>
>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
>
> Out of curiosity, how did you identify this issue?

These kind of issues are hard not to notice when using shared library 
configuration once there's something actually using the symbol. In this 
case, the four commits following 719dbebceb81 make the e1000, ixgbe, i40 
and fm10k pmds unloadable respectively:

librte_pmd_ixgbe.so: undefined symbol: rte_eth_dma_zone_reserve

Driver autoloading does help unearthing these issues too since all the 
pmd's get loaded regardless of the actual hardware present.

	- Panu -
Thomas Monjalon Nov. 23, 2015, 9:22 p.m. UTC | #3 
> > Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
> > 
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
index 11c4e94..0c35d53 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -133,6 +133,7 @@  DPDK_2.2 {
 
 	rte_eth_copy_pci_info;
 	rte_eth_dev_get_dcb_info;
+	rte_eth_dma_zone_reserve;
 	rte_eth_rx_queue_info_get;
 	rte_eth_timesync_adjust_time;
 	rte_eth_timesync_read_time;