[dpdk-dev,v3] librte_eal/common: Fix cast from pointer to integer of different size

Hi Thomas  and all :

  I686   gcc and icc targets both have the below build issue:

For GCC(after apply the patch :[dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size    )

== Build lib/librte_hash
  CC rte_hash.o
/jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_32_BUILD2/DPDK/lib/librte_hash/rte_hash_crc.h: Assembler messages:
/jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_32_BUILD2/DPDK/lib/librte_hash/rte_hash_crc.h:380: Error: unsupported instruction `crc32'
/jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_32_BUILD2/DPDK/lib/librte_hash/rte_hash_crc.h:380: Error: unsupported instruction `crc32'
gmake[5]: *** [rte_hash.o] Error 1
gmake[4]: *** [librte_hash] Error 2
gmake[3]: *** [lib] Error 2
gmake[2]: *** [all] Error 2
gmake[1]: *** [i686-native-linuxapp-gcc_install] Error 2
gmake: *** [install] Error 2

For ICC :
== Build lib/librte_hash
  CC rte_hash.o
/tmp/iccOsnsZzas_.s: Assembler messages:
/tmp/iccOsnsZzas_.s:49: Error: unsupported instruction `crc32'
/tmp/iccOsnsZzas_.s:133: Error: unsupported instruction `crc32'
make[5]: *** [rte_hash.o] Error 1
make[4]: *** [librte_hash] Error 2
make[3]: *** [lib] Error 2
make[2]: *** [all] Error 2
make[1]: *** [i686-native-linuxapp-icc_install] Error 2
make: *** [install] Error 2

Can anyone can help to check the assemble code .

thanks


-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
Sent: Thursday, March 05, 2015 3:47 PM
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size

./i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

  dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;

Type 'long long' is 64-bit in i686 platform while 'void *'
is 32-bit.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
v3 --> v2:
	make dstofss and srcofs to be type size_t
	casting type use uintptr_t

v2 --> v1:
	Remove unnecessary casting (void *)
 lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

 	 * unaligned copy functions require up to 15 bytes
 	 * backwards access.
 	 */
-	dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
+	dstofss = 16 - ((uintptr_t)dst & 0x0F) + 16;
 	n -= dstofss;
 	rte_mov32((uint8_t *)dst, (const uint8_t *)src);
 	src = (const uint8_t *)src + dstofss;
 	dst = (uint8_t *)dst + dstofss;
-	srcofs = (int)((long long)(const void *)src & 0x0F);
+	srcofs = (uintptr_t)src & 0x0F;
 
 	/**
 	 * For aligned copy
--
1.9.3
  

2015-03-05 09:21, Tang, HaifengX:
> Hi Thomas  and all :
[...]
>   CC rte_hash.o
> /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_32_BUILD2/DPDK/lib/librte_hash/rte_hash_crc.h: Assembler messages:
> /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_32_BUILD2/DPDK/lib/librte_hash/rte_hash_crc.h:380: Error: unsupported instruction `crc32'
> /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_32_BUILD2/DPDK/lib/librte_hash/rte_hash_crc.h:380: Error: unsupported instruction `crc32'
[...]
>   CC rte_hash.o
> /tmp/iccOsnsZzas_.s: Assembler messages:
> /tmp/iccOsnsZzas_.s:49: Error: unsupported instruction `crc32'
> /tmp/iccOsnsZzas_.s:133: Error: unsupported instruction `crc32'
[...]
> Can anyone can help to check the assemble code .

These errors are related to
"[PATCH v6 2/7] hash: add assembly implementation of CRC32 intrinsics"

Please ask in the right thread.
Yerden should know how to properly fix this problem.

Thanks