[dpdk-dev,v3] librte_eal/common: Fix cast from pointer to integer of different size
Commit Message
Tested-by: haifeng.tang <haifengx.tang@intel.com>
Patch name: [dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size
Test Env :
Fedora 18 , 3.6.10-4 ,4.7.2 ,14.0.0
Fedora20 ,3.11.0,4.8.2,14.0.0
Fedora21,3.17.4-302,4.9.2,15.0.0
Ubuntu 14.04, 3.13.0-30, 4.8.2, 14.0.0
Test Result:
error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] problem fixed now
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
Sent: Thursday, March 05, 2015 3:47 PM
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3] librte_eal/common: Fix cast from pointer to integer of different size
./i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
Type 'long long' is 64-bit in i686 platform while 'void *'
is 32-bit.
Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
v3 --> v2:
make dstofss and srcofs to be type size_t
casting type use uintptr_t
v2 --> v1:
Remove unnecessary casting (void *)
lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
* unaligned copy functions require up to 15 bytes
* backwards access.
*/
- dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
+ dstofss = 16 - ((uintptr_t)dst & 0x0F) + 16;
n -= dstofss;
rte_mov32((uint8_t *)dst, (const uint8_t *)src);
src = (const uint8_t *)src + dstofss;
dst = (uint8_t *)dst + dstofss;
- srcofs = (int)((long long)(const void *)src & 0x0F);
+ srcofs = (uintptr_t)src & 0x0F;
/**
* For aligned copy
--
1.9.3
@@ -493,8 +493,8 @@ rte_memcpy(void *dst, const void *src, size_t n) {
__m128i xmm0, xmm1, xmm2, xmm3, xmm4, xmm5, xmm6, xmm7, xmm8;
void *ret = dst;
- int dstofss;
- int srcofs;
+ size_t dstofss;
+ size_t srcofs;
/**
* Copy less than 16 bytes
@@ -589,12 +589,12 @@ COPY_BLOCK_64_BACK15: