From patchwork Thu Nov 27 14:52:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sujith Sankar X-Patchwork-Id: 1657 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 8EBCC2E81; Thu, 27 Nov 2014 15:53:19 +0100 (CET) Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) by dpdk.org (Postfix) with ESMTP id 6FB362A9 for ; Thu, 27 Nov 2014 15:53:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6518; q=dns/txt; s=iport; t=1417099998; x=1418309598; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=9phEgXyl82xUYyMcOUpi57HlU7zCF8ZTpoL3W+YCKgA=; b=dEfBF6aJp/dOu/uUdTO53hgrYBPnBMRcwdmhNjeErPKb5p7HVNecTvg3 iCbx0G0iB9L/NZwOnSu84kliU0PzoUblXCaxjz3bGnDsgr5J3ncJOgj2N foh5I6QdqDIxdRI/uWshOMYN9ErbJzFv5naWnJWwqxBxn22sXA1humt14 U=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgkFAJk6d1StJV2c/2dsb2JhbABbgkJEgS3ODgKBChYBAQEBAX2EAgEBAQR5EAIBCBEDAQIoBzIUCQgCBA4FiEDSPgEBAQEBAQEBAQEBAQEBAQEBAQEBAReQLT0RB4RNBZA5giyMHIE1g1mOBIQKg3xvAYFHgQIBAQE X-IronPort-AV: E=Sophos;i="5.07,469,1413244800"; d="scan'208,217";a="375863856" Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by rcdn-iport-4.cisco.com with ESMTP; 27 Nov 2014 14:52:53 +0000 Received: from xhc-rcd-x14.cisco.com (xhc-rcd-x14.cisco.com [173.37.183.88]) by rcdn-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id sAREqqFu018027 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 27 Nov 2014 14:52:52 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.173]) by xhc-rcd-x14.cisco.com ([173.37.183.88]) with mapi id 14.03.0195.001; Thu, 27 Nov 2014 08:52:52 -0600 From: "Sujith Sankar (ssujith)" To: David Marchand Thread-Topic: [PATCH] config: disable enic driver on Power Thread-Index: AQHQCjdx8hgfksKyHUiHMfMdYtYoV5x1T/8A Date: Thu, 27 Nov 2014 14:52:51 +0000 Message-ID: References: <1417088558-13055-1-git-send-email-david.marchand@6wind.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.65.33.70] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] config: disable enic driver on Power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, I shall take a look at it get back soon after some tests. One point here is that ENICPMD will be used only on UCS servers (as Cisco VIC cards are shipped only with them) and they are all x86_64. So you could turn it off for all the other architectures. Thanks, -Sujith From: David Marchand > Date: Thursday, 27 November 2014 5:14 pm To: "Sujith Sankar (ssujith)" > Cc: Chao Zhu >, "dev@dpdk.org" > Subject: Re: [PATCH] config: disable enic driver on Power Hello Sujith, Please can you have a look at this in your enic driver ? I find it weird to use these types while we could use types such as uint8_t etc... Thanks. --- David Marchand On Thu, Nov 27, 2014 at 12:42 PM, David Marchand > wrote: enic driver is giving trouble because of non-standard types : CC enic_res.o In file included from lib/librte_pmd_enic/enic_res.c:36:0: lib/librte_pmd_enic/enic_compat.h:92:1: error: unknown type name ‘u_int32_t’ static inline u_int32_t ioread32(volatile void *addr) ^ Disable it on Power for now. Signed-off-by: David Marchand > --- config/defconfig_ppc_64-power8-linuxapp-gcc | 1 + 1 file changed, 1 insertion(+) -- 1.7.10.4 diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/defconfig_ppc_64-power8-linuxapp-gcc index cefb3be..48018c3 100644 --- a/config/defconfig_ppc_64-power8-linuxapp-gcc +++ b/config/defconfig_ppc_64-power8-linuxapp-gcc @@ -52,6 +52,7 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n CONFIG_RTE_LIBRTE_VIRTIO_PMD=n CONFIG_RTE_LIBRTE_VMXNET3_PMD=n CONFIG_RTE_LIBRTE_PMD_BOND=n +CONFIG_RTE_LIBRTE_ENIC_PMD=n # This following libraries are not available on Power. So they're turned off. CONFIG_RTE_LIBRTE_LPM=n