diff mbox

[dpdk-dev] rte_memcpy.h: additional cflags required with OVS

Message ID B27915DBBA3421428155699D51E4CFE2ECC997@IRSMSX103.ger.corp.intel.com (mailing list archive)
State Not Applicable, archived
Headers

Commit Message

John McNamara March 10, 2015, 12:57 a.m. UTC 
  > -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> Sent: Monday, March 9, 2015 5:51 PM
> To: Kavanagh, Mark B; dev@dpdk.org
> Subject: Re: [dpdk-dev] rte_memcpy.h: additional cflags required with OVS


>> In the meantime the following might work for OVS:
>> 
>>     $ ./configure CFLAGS='-Wno-bad-function-cast -march=native' --with-
>> dpdk=$DPDK_BUILD
>>     $ make
>> 
>> 


Hi,

It will also need a patch like the following to netdev-dpdk to account for changes in the RSS flags:

$ git diff

Comments

Michael Qiu March 10, 2015, 3 a.m. UTC | #1 
On 3/10/2015 8:57 AM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
>> Sent: Monday, March 9, 2015 5:51 PM
>> To: Kavanagh, Mark B; dev@dpdk.org
>> Subject: Re: [dpdk-dev] rte_memcpy.h: additional cflags required with OVS
>
>>> In the meantime the following might work for OVS:
>>>
>>>     $ ./configure CFLAGS='-Wno-bad-function-cast -march=native' --with-
>>> dpdk=$DPDK_BUILD
>>>     $ make
>>>
>>>
>
> Hi,
>
> It will also need a patch like the following to netdev-dpdk to account for changes in the RSS flags:
>
> $ git diff
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index 1ba8310..90dd06f 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -97,8 +97,7 @@ static const struct rte_eth_conf port_conf = {
>      .rx_adv_conf = {
>          .rss_conf = {
>              .rss_key = NULL,
> -            .rss_hf = ETH_RSS_IPV4_TCP | ETH_RSS_IPV4 | ETH_RSS_IPV6
> -                    | ETH_RSS_IPV4_UDP | ETH_RSS_IPV6_TCP | ETH_RSS_IPV6_UDP,
> +            .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP,
>          },
>      },
>      .txmode = {
>
>  

Yes, otherwise will lead a compile failure.

Thanks,
Michael
>
Mark Kavanagh March 10, 2015, 9:16 a.m. UTC | #2 
>-----Original Message-----
>From: Mcnamara, John
>Sent: Tuesday, March 10, 2015 12:57 AM
>To: Mcnamara, John; Kavanagh, Mark B; dev@dpdk.org
>Subject: RE: rte_memcpy.h: additional cflags required with OVS
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
>> Sent: Monday, March 9, 2015 5:51 PM
>> To: Kavanagh, Mark B; dev@dpdk.org
>> Subject: Re: [dpdk-dev] rte_memcpy.h: additional cflags required with OVS
>
>
>>> In the meantime the following might work for OVS:
>>>
>>>     $ ./configure CFLAGS='-Wno-bad-function-cast -march=native' --with-
>>> dpdk=$DPDK_BUILD
>>>     $ make
>>>
>>>
>
>
>Hi,
>
>It will also need a patch like the following to netdev-dpdk to account for changes in the
>RSS flags:
>
Thanks John, both myself and Panu had already caught this :)
>$ git diff
>diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
>index 1ba8310..90dd06f 100644
>--- a/lib/netdev-dpdk.c
>+++ b/lib/netdev-dpdk.c
>@@ -97,8 +97,7 @@ static const struct rte_eth_conf port_conf = {
>     .rx_adv_conf = {
>         .rss_conf = {
>             .rss_key = NULL,
>-            .rss_hf = ETH_RSS_IPV4_TCP | ETH_RSS_IPV4 | ETH_RSS_IPV6
>-                    | ETH_RSS_IPV4_UDP | ETH_RSS_IPV6_TCP | ETH_RSS_IPV6_UDP,
>+            .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP,
>         },
>     },
>     .txmode = {
>
>
diff mbox

Patch

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 1ba8310..90dd06f 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -97,8 +97,7 @@  static const struct rte_eth_conf port_conf = {
     .rx_adv_conf = {
         .rss_conf = {
             .rss_key = NULL,
-            .rss_hf = ETH_RSS_IPV4_TCP | ETH_RSS_IPV4 | ETH_RSS_IPV6
-                    | ETH_RSS_IPV4_UDP | ETH_RSS_IPV6_TCP | ETH_RSS_IPV6_UDP,
+            .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP,
         },
     },
     .txmode = {