From patchwork Fri Oct 20 16:33:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John McNamara X-Patchwork-Id: 30653 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 785231B291; Fri, 20 Oct 2017 18:33:21 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2E6C61B290 for ; Fri, 20 Oct 2017 18:33:19 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2017 09:33:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.43,405,1503385200"; d="scan'208"; a="1027414315" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 20 Oct 2017 09:33:17 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX101.ger.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0319.002; Fri, 20 Oct 2017 17:33:14 +0100 From: "Mcnamara, John" To: Ori Kam , "adrien.mazarguil@6wind.com" , "thomas@monjalon.net" CC: "dev@dpdk.org" Thread-Topic: [PATCH 2/2] doc: add flow_filtering example documentation Thread-Index: AQHTSMNjC68lWWE6AkSVbp7UcewwtaLs7/dg Date: Fri, 20 Oct 2017 16:33:12 +0000 Message-ID: References: <1508408167-9001-1-git-send-email-orika@mellanox.com> In-Reply-To: <1508408167-9001-1-git-send-email-orika@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjgyNzBjMTMtZGRiYS00ZWQ1LWJiNDAtMjIyY2IxZDhmNzdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZKdnNHT21qb2RvOXRXMHdxUUU5QWRTTDJua2ZIWnBlWXk5TTRFQ3ZoR3M9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add flow_filtering example documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ori Kam [mailto:orika@mellanox.com] > Sent: Thursday, October 19, 2017 11:16 AM > To: adrien.mazarguil@6wind.com; Mcnamara, John ; > thomas@monjalon.net > Cc: dev@dpdk.org; orika@mellanox.com > Subject: [PATCH 2/2] doc: add flow_filtering example documentation > > Signed-off-by: Ori Kam Hi, 1. This file needs to be included in the index.rst file. 2. There is a doc compilation issue due to a missing blank line after one of the code-block sections. 3. There is a white space warning on merge. Apart from that the doc looks good. Below are the changes I made to get it to compile. John $ git diff diff --git a/doc/guides/sample_app_ug/flow_filtering.rst b/doc/guides/sample_app_ug/flow_filtering.rst index b8d59af..f2d7db2 100644 --- a/doc/guides/sample_app_ug/flow_filtering.rst +++ b/doc/guides/sample_app_ug/flow_filtering.rst @@ -113,7 +113,8 @@ The ``main()`` also allocates a mempool to hold the mbufs (Message Buffers) used by the application: .. code-block:: c - mbuf_pool = rte_pktmbuf_pool_create("mbuf_pool", 4096, 128, 0, + + mbuf_pool = rte_pktmbuf_pool_create("mbuf_pool", 4096, 128, 0, RTE_MBUF_DEFAULT_BUF_SIZE, rte_socket_id()); @@ -536,4 +537,3 @@ The last part of the function is to validate the rule and create it. int res = rte_flow_validate(port_id, &attr, pattern, action, &error); if (!res) flow = rte_flow_create(port_id, &attr, pattern, action, &error); - diff --git a/doc/guides/sample_app_ug/index.rst b/doc/guides/sample_app_ug/index.rst index 069d4f1..ca1f544 100644 --- a/doc/guides/sample_app_ug/index.rst +++ b/doc/guides/sample_app_ug/index.rst @@ -77,6 +77,7 @@ Sample Applications User Guides ptpclient performance_thread ipsec_secgw + flow_filtering **Figures**