From patchwork Sat Mar 2 12:10:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50768 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54CC54F9B; Sat, 2 Mar 2019 13:11:00 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690071.outbound.protection.outlook.com [40.107.69.71]) by dpdk.org (Postfix) with ESMTP id 51CA54F98 for ; Sat, 2 Mar 2019 13:10:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OfG3GqGxL48e9NnuRvDdyNCEusVHw/iV4qz6kvI1OLE=; b=JcdT7h+QvKL5Ik0qMwIrVg+fowCFGgF8m3eAFMW844BBl0JhaKzdh1FDJ0fapSr6U/CUV4Sxt2WTICBjfPhVFzAXxTiqqKRBFoNEqS58O5aA/ZMNHyxuv8ipnxUMLjvjc6hhsKV1s3IYAn8QgIkD8KQlsf5tdQr/OV1nsvWkUa8= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:57 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:57 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 08/10] net/atlantic: eliminate excessive log levels on rx/tx Thread-Index: AQHU0PD9nduY1Cz6s0aayOstP0WFAA== Date: Sat, 2 Mar 2019 12:10:56 +0000 Message-ID: <997f7e5e1eab9c5af41aa9c05140a2fd72a3b221.1551528549.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5e1fe0b6-7413-44fd-2e5f-08d69f081ffc x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:h7ACrM962Ml4Q2Ld9eDgb6YN23ps/Z9wM/WatsH?= =?iso-8859-1?q?dDz4VHamzZcKcwTm7efI+PrVc?= =?iso-8859-1?q?BiPnqbUoeOO1FnhpegYlry3wyrSum6OVvjygO+Q37jW48Y92f2A?= =?iso-8859-1?q?GNLimfi6i0A71ydw8aIMVp6AkVSOzxHXnsqmaUeRn7Pbsq+XWEu?= =?iso-8859-1?q?mYLxIGRwEkkFlCOEV/9qOZ4xLv258QKUfexclv92BJhidJvpj50?= =?iso-8859-1?q?8jj3CVt9HKW1z3KRXBkqkWCXGwT9ZMOA9SrgfxDQeDaMkhtrxyo?= =?iso-8859-1?q?aNjXtjLFeoTkQlhEtiUZLqLRdJ8oMVvZE8AGemd0CyfZm1DJ7Mq?= =?iso-8859-1?q?8Xpw5aXDjzzRFNYXYa+f+x8Q1fx+2CNwHu44wLzFI87Wvac8bJ5?= =?iso-8859-1?q?vKRZWl/u4UEMRZ5SFpfhV5lWIuBIsSsBLE3eP4Y171ZKaNZQb0B?= =?iso-8859-1?q?5l036MpqbWIXHsAFVm172nP0PtWbGJuWlhncPJib7DR6K5DPUOP?= =?iso-8859-1?q?oAh+ogohCxECeKYH4yWuh4gK/Que41y7MCMGcQopK1V6w8knqiS?= =?iso-8859-1?q?e5NoqqLxvmgg9Ud7i19P+s2HGHOckKpmoHqcpF9YmvLVR4SFDq5?= =?iso-8859-1?q?f1R+NrjQkn8EtyOyeK4N1iNdIKLSGzQOTf1prSdCvu/I5NCtFzi?= =?iso-8859-1?q?LMLJLlXxOXiPPwSB3+iP0zh5BJvt0VYqiL8dD4ewM/SKUEyjBdl?= =?iso-8859-1?q?Svg6Wlb9MSxvTFsI+zXlnBbYYVsAPB04Iaoj85yARu1uY1Hy4E0?= =?iso-8859-1?q?YHT5JKvaS8Z62xbqxyNfwDjHQwkpDSu2YyEGmVSv1zgDS81C+Gy?= =?iso-8859-1?q?IA+WEVnyTDZ043z6MmnipCECZduXSe/TuAxEe3GBQ3RJiYJBG+3?= =?iso-8859-1?q?d3u82aluwB/XxMgs+sF/6CXTy6kuQG4f6XR6FIVVBfdB5TloEis?= =?iso-8859-1?q?8WRA3wmVoxGGk9ncACmE5VbjiziiCUFnMkcAR8ztM7wYYtvMsZS?= =?iso-8859-1?q?0e5uNIbsmGshmGUQ89WLIm17iCw9NjdInZ4ZYKXQaGl9OiME0vj?= =?iso-8859-1?q?4LQWOUEQD13UhuowBjAHKgcKm3LHPDX+qGq7szRMxvjRzKXr6vI?= =?iso-8859-1?q?wLKy4V4RTpbAUHma3nwjfRIe0L1sCYb1isVIZzpqaQdAh09xKSG?= =?iso-8859-1?q?wkiQ2E0YLFNxVjNbocpThS+X3EKw/y6e7t7ZPY6MnGOafPU9s32?= =?iso-8859-1?q?ok0lJ+jJ/hypLZE2wCO1T82QKo2FxVsh5K4N8Dx6YvInRKTX0aB?= =?iso-8859-1?q?JGaJEh5pBDE+OYI5KpoQuaQ94+6l6vj93FEmbmn3rgobuE29tCm?= =?iso-8859-1?q?aNQn9cn7luuT13TrmFHBepiwMz7LMZgLlSc/LMum6pZKRzND25f?= =?iso-8859-1?q?PZcWcbRENGpGZ2eQDhgyvyIXytwgSElsa+dYBvP0OtpgWf5x+fQ?= =?iso-8859-1?q?7Wd5Fk91/CenchkUyXsOi3FViLg=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0Kj28n+5NmA8Xtrs9SDetNuwZ2OWaCUDDbCkw1dpCL9EBYbMLS3bg56RexamNvQYsBYlPYBJXH7cJWvttNKbi5Aq+USj2QFEwk8YjWqvjiuw8SkvMsToJcVF3OC2hDFqgBv+8JLHbO3F6uUEaMaBwUR3sAD0pU3eKCNupolztvVEYiN0WP3aqwc9fiZ0ahEZYQ+oDqVTNWWlaSGuXux8vdM0E3c8/VDOswtObPqxuim4j5a4yJJY69LHPs3MmCUgyvskjvak1BzqTWRJ+LPHbbfPTo4CKIpH2ATQmf/mLh3fb5QsxRC0Dee07I5L45IOAyEERCjMgZRLKs1DnzH3YOlmmk2hG/G5wWiKtn9oBDZyS8MMrSrmd4/f/kf6VFXyAEkOio8Wmtvg4xWS8bmtxOdtKGioTGPM++yDJB+uw08= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e1fe0b6-7413-44fd-2e5f-08d69f081ffc X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:55.3441 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 08/10] net/atlantic: eliminate excessive log levels on rx/tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Default rxtx logging used ERR level, that caused logger to always trigger. That caused perf degradation even if logger was not enabled but compiled in. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_rxtx.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index aea58c0d5..f1519594a 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -946,7 +946,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) break; } - PMD_RX_LOG(ERR, "port_id=%u queue_id=%u tail=%u " + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u tail=%u " "eop=0x%x pkt_len=%u hash=0x%x hash_type=0x%x", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id, @@ -981,7 +981,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) while (true) { new_mbuf = rte_mbuf_raw_alloc(rxq->mb_pool); if (new_mbuf == NULL) { - PMD_RX_LOG(ERR, + PMD_RX_LOG(DEBUG, "RX mbuf alloc failed port_id=%u " "queue_id=%u", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id); @@ -1084,7 +1084,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) adapter->sw_stats.q_ibytes[rxq->queue_id] += rx_mbuf_first->pkt_len; - PMD_RX_LOG(ERR, "add mbuf segs=%d pkt_len=%d", + PMD_RX_LOG(DEBUG, "add mbuf segs=%d pkt_len=%d", rx_mbuf_first->nb_segs, rx_mbuf_first->pkt_len); } @@ -1104,7 +1104,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) */ nb_hold = (uint16_t)(nb_hold + rxq->nb_rx_hold); if (nb_hold > rxq->rx_free_thresh) { - PMD_RX_LOG(ERR, "port_id=%u queue_id=%u rx_tail=%u " + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_tail=%u " "nb_hold=%u nb_rx=%u", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id, (unsigned int)tail, (unsigned int)nb_hold, @@ -1129,8 +1129,6 @@ atl_xmit_cleanup(struct atl_tx_queue *txq) struct hw_atl_txd_s *txd; int to_clean = 0; - PMD_INIT_FUNC_TRACE(); - if (txq != NULL) { sw_ring = txq->sw_ring; int head = txq->tx_head; @@ -1181,11 +1179,7 @@ atl_tso_setup(struct rte_mbuf *tx_pkt, union hw_atl_txc_s *txc) uint32_t tx_cmd = 0; uint64_t ol_flags = tx_pkt->ol_flags; - PMD_INIT_FUNC_TRACE(); - if (ol_flags & PKT_TX_TCP_SEG) { - PMD_DRV_LOG(DEBUG, "xmit TSO pkt"); - tx_cmd |= tx_desc_cmd_lso | tx_desc_cmd_l4cs; txc->cmd = 0x4; @@ -1240,8 +1234,6 @@ atl_xmit_pkt(struct aq_hw_s *hw, struct atl_tx_queue *txq, u32 tx_cmd = 0U; int desc_count = 0; - PMD_INIT_FUNC_TRACE(); - tail = txq->tx_tail; txc = (union hw_atl_txc_s *)&txq->hw_ring[tail];