From patchwork Thu Dec 13 11:43:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatoly Burakov X-Patchwork-Id: 48765 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A95E71B517; Thu, 13 Dec 2018 12:43:32 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 9CF2F1B4F5 for ; Thu, 13 Dec 2018 12:43:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 03:43:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,348,1539673200"; d="scan'208";a="98448780" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga007.jf.intel.com with ESMTP; 13 Dec 2018 03:43:21 -0800 Received: from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com [10.243.17.64]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id wBDBhKZs032163; Thu, 13 Dec 2018 11:43:20 GMT Received: from sivswdev05.ir.intel.com (localhost [127.0.0.1]) by sivswdev05.ir.intel.com with ESMTP id wBDBhKFd012569; Thu, 13 Dec 2018 11:43:20 GMT Received: (from aburakov@localhost) by sivswdev05.ir.intel.com with LOCAL id wBDBhKv4012565; Thu, 13 Dec 2018 11:43:20 GMT From: Anatoly Burakov To: dev@dpdk.org Cc: przemyslawx.lal@intel.com, kuralamudhan.ramakrishnan@intel.com, ivan.coughlan@intel.com, tiwei.bie@intel.com, ray.kinsella@intel.com, maxime.coquelin@redhat.com Date: Thu, 13 Dec 2018 11:43:19 +0000 Message-Id: <98395a6100625b09e0477a665c687ba69c6f9e99.1544701282.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v3 5/5] test: add segment fd API test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Use memory autotest to also test segment fd API. This will not do any checks - just see if the relevant API's return success or indicate that the API is not supported. Signed-off-by: Anatoly Burakov Acked-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- test/test/test_memory.c | 43 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/test/test/test_memory.c b/test/test/test_memory.c index b96bca771..3da803e4e 100644 --- a/test/test/test_memory.c +++ b/test/test/test_memory.c @@ -37,10 +37,44 @@ check_mem(const struct rte_memseg_list *msl __rte_unused, return 0; } +static int +check_seg_fds(const struct rte_memseg_list *msl, const struct rte_memseg *ms, + void *arg __rte_unused) +{ + size_t offset; + int ret; + + /* skip external segments */ + if (msl->external) + return 0; + + /* try segment fd first. we're in a callback, so thread-unsafe */ + ret = rte_memseg_get_fd_thread_unsafe(ms); + if (ret < 0) { + /* ENOTSUP means segment is valid, but there is not support for + * segment fd API (e.g. on FreeBSD). + */ + if (errno == ENOTSUP) + return 1; + /* all other errors are treated as failures */ + return -1; + } + + /* we're able to get memseg fd - try getting its offset */ + ret = rte_memseg_get_fd_offset_thread_unsafe(ms, &offset); + if (ret < 0) { + if (errno == ENOTSUP) + return 1; + return -1; + } + return 0; +} + static int test_memory(void) { uint64_t s; + int ret; /* * dump the mapped memory: the python-expect script checks @@ -59,6 +93,15 @@ test_memory(void) /* try to read memory (should not segfault) */ rte_memseg_walk(check_mem, NULL); + /* check segment fd support */ + ret = rte_memseg_walk(check_seg_fds, NULL); + if (ret == 1) { + printf("Segment fd API is unsupported\n"); + } else if (ret == -1) { + printf("Error getting segment fd's\n"); + return -1; + } + return 0; }