diff mbox

[dpdk-dev] mk: crypto pmds can only be built if librte_cryptodev is enabled

Message ID 9127451bf67ce08532a327cb66aefbcf7ed5b39f.1457687628.git.pmatilai@redhat.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Panu Matilainen March 11, 2016, 9:13 a.m. UTC 
  If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
build of any crypto pmds will fail because of the missing dependency.
This has been present for a while now but hidden until the addition
of null_crypto since all the other crypto pmds have been disabled
by default.

Conditionalize the entire drivers/crypto directory on
CONFIG_RTE_LIBRTE_CRYPTODEV to fix.

Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 drivers/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon March 11, 2016, 9:28 a.m. UTC | #1 
2016-03-11 11:13, Panu Matilainen:
> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
> build of any crypto pmds will fail because of the missing dependency.
> This has been present for a while now but hidden until the addition
> of null_crypto since all the other crypto pmds have been disabled
> by default.

Good catch, thanks.

> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>  DIRS-y += crypto
> +endif

Why not 
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto ?
Panu Matilainen March 11, 2016, 9:38 a.m. UTC | #2 
On 03/11/2016 11:28 AM, Thomas Monjalon wrote:
> 2016-03-11 11:13, Panu Matilainen:
>> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
>> build of any crypto pmds will fail because of the missing dependency.
>> This has been present for a while now but hidden until the addition
>> of null_crypto since all the other crypto pmds have been disabled
>> by default.
>
> Good catch, thanks.
>
>> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>>  DIRS-y += crypto
>> +endif
>
> Why not
> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto ?

Just because old habits ... and ... you know :)

Should I send a new version or can you fix that up when committing?

	- Panu -
Thomas Monjalon March 11, 2016, 9:40 a.m. UTC | #3 
2016-03-11 11:13, Panu Matilainen:
> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
> build of any crypto pmds will fail because of the missing dependency.
> This has been present for a while now but hidden until the addition
> of null_crypto since all the other crypto pmds have been disabled
> by default.
> 
> Conditionalize the entire drivers/crypto directory on
> CONFIG_RTE_LIBRTE_CRYPTODEV to fix.
> 
> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
> 
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>

Applied with small rework, thanks.

> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>  DIRS-y += crypto
> +endif
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
diff mbox

Patch

diff --git a/drivers/Makefile b/drivers/Makefile
index 6ec67f6..c6758a1 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -32,6 +32,8 @@ 
 include $(RTE_SDK)/mk/rte.vars.mk
 
 DIRS-y += net
+ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
 DIRS-y += crypto
+endif
 
 include $(RTE_SDK)/mk/rte.subdir.mk