From patchwork Tue Jan 23 08:05:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 34298 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FADB727A; Tue, 23 Jan 2018 09:05:29 +0100 (CET) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id CA5D5A49C for ; Tue, 23 Jan 2018 09:05:25 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id f71so19963wmf.0 for ; Tue, 23 Jan 2018 00:05:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=vcb7Lt4evaWM3DXYc6C7E72B2LC35CYfrXIhaU1ptp0=; b=cCxnuhZQp7tsOoxwsx/E6V39G+u6s2w84XVHZHYc8doyfy0fGtP59Oo9h0ZvWBAkbm NaqNttsSWQ8xg+KETCCdT24kQXjqAGB+XbKlcWyl7MRYthr9LwGMYF5olZHcEDv3OB5D 6xgbD+ETh6T8bRWYQfyzc+zyim3EvNrJkQy9hxS7NXb2z5eETVKyb0B5d+H1fHL2KWlf DR38DxdwWkPwhJdViRaqhxQLmIWuRmh2J/0pXlB1oIw5cFH80VEVIq21HyfQIPJ/j5Xb PnVPoaRlTIdqj26jexYx0TZJr/iDux0+SOch5c5bB0XUK/lrYYGBp7i0lk8PFQBH9J6Z hzeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=vcb7Lt4evaWM3DXYc6C7E72B2LC35CYfrXIhaU1ptp0=; b=fuer/QZexkX0BTQE0XCXFJ7qhy/AQC8rqRD/6rJ6td7pvZ8+kL1m4clVsHTNY13ist CftCchKcGFY9h/m75UKgwxbRxKCAPlCMHhmhk7tfJMkhsD3dftx1JtHXr0Yjog2q2/li 7E8ZUgfiVS4w/g0YJTzaUdnOPJ0mcscwNyvLTVCHVapAauX8iqyCpdtlE93o9TqO2Gmo MBVb/e8jl/A0B4rt5G+eFeKhi9pOrFCsCVAOBRj/l77emRqd/m6Pi2JxTxYVfbBagoGi LN8jM+2bpQ5A0xu1Va7yERM0EWpiHDaHI7SECXKNHvMyFJ3DOTJFwAfvxFmnxWU0U5yR V3HQ== X-Gm-Message-State: AKwxytfHleagSW6idfDJ0uR28UGPic4jTzdtZjMf2sTc0gXmQURbYfj4 i+N+sZJ9d9E6fMcEW33AVMzeAX4XMw== X-Google-Smtp-Source: AH8x22568F2jG50VraWx7ikVezkVr2egr7V+sldJiQmcOgcBIZ4DlVBiDf2sZS7ypsoJpeBlPga5dA== X-Received: by 10.28.137.85 with SMTP id l82mr1090905wmd.109.1516694725269; Tue, 23 Jan 2018 00:05:25 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 39sm24642999wrz.93.2018.01.23.00.05.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jan 2018 00:05:24 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org, Shahaf Shuler Cc: Adrien Mazarguil , stable@dpdk.org Date: Tue, 23 Jan 2018 09:05:09 +0100 Message-Id: <904aa327d4d0761ba960377c8a299eaafa01927d.1516694692.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 2/3] net/mlx5: fix flow item validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Two masks were compared instead of verifying the spec was included in the supported mask. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index c56ef54cf..01e290484 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -529,7 +529,7 @@ mlx5_flow_item_validate(const struct rte_flow_item *item, } if (item->mask) { unsigned int i; - const uint8_t *spec = item->mask; + const uint8_t *spec = item->spec; for (i = 0; i < size; ++i) if ((spec[i] | mask[i]) != mask[i])