diff mbox series

[21.02,v2] mem: don't warn about base addr if not requested

Message ID 8f49e252a7be2d8561f4b32193e5800f98c40b0e.1604936860.git.anatoly.burakov@intel.com (mailing list archive)
State New
Delegated to: Thomas Monjalon
Headers show
Series [21.02,v2] mem: don't warn about base addr if not requested | expand

Checks

Context Check Description
ci/travis-robot success Travis build: passed
ci/checkpatch success coding style OK

Commit Message

Anatoly Burakov Nov. 9, 2020, 3:47 p.m. UTC
Any EAL memory allocation often goes through eal_get_virtual_area()
function, which will print a warning whenever the resulting allocation
didn't match the specified address requirements. This is useful for
when we have requested a specific base virtual address, to let the user
know that the mapping has deviated from that address.

However, on Linux, we also have a default base address that's there to
ensure better chances of successful secondary process initialization,
as well as higher likelihood of the virtual areas to fit inside the
IOMMU address width. Because of this default base address, there are
warnings printed even when no base address was explicitly requested,
which can be confusing to the user.

Emit this warning with debug level unless base address was explicitly
requested by the user.

Cc: Damjan Marion <damarion@cisco.com>

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---

Notes:
    v2:
    - Fix the condition to not update the address incorrectly
    - Instead of removing the warning, let it have debug level unless base address
      was explicitly specified by the user
    
    I'm not entirely sure the trade off between user confusion and helpful debug
    information is worth it, but in my experience, i've stopped getting any emails
    about secondary processes a long time ago and this isn't a widely used feature,
    so i believe this is worth it.

 lib/librte_eal/common/eal_common_memory.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

Comments

David Marchand Jan. 12, 2021, 10:29 a.m. UTC | #1
On Mon, Nov 9, 2020 at 4:48 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> Any EAL memory allocation often goes through eal_get_virtual_area()
> function, which will print a warning whenever the resulting allocation
> didn't match the specified address requirements. This is useful for
> when we have requested a specific base virtual address, to let the user
> know that the mapping has deviated from that address.
>
> However, on Linux, we also have a default base address that's there to
> ensure better chances of successful secondary process initialization,
> as well as higher likelihood of the virtual areas to fit inside the
> IOMMU address width. Because of this default base address, there are
> warnings printed even when no base address was explicitly requested,
> which can be confusing to the user.
>
> Emit this warning with debug level unless base address was explicitly
> requested by the user.
>
> Cc: Damjan Marion <damarion@cisco.com>
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>
> Notes:
>     v2:
>     - Fix the condition to not update the address incorrectly
>     - Instead of removing the warning, let it have debug level unless base address
>       was explicitly specified by the user
>
>     I'm not entirely sure the trade off between user confusion and helpful debug
>     information is worth it, but in my experience, i've stopped getting any emails
>     about secondary processes a long time ago and this isn't a widely used feature,
>     so i believe this is worth it.
>
>  lib/librte_eal/common/eal_common_memory.c | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
> index 33917fa835..1b50c2099d 100644
> --- a/lib/librte_eal/common/eal_common_memory.c
> +++ b/lib/librte_eal/common/eal_common_memory.c
> @@ -140,9 +140,19 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
>                 return NULL;
>         } else if (requested_addr != NULL && addr_is_hint &&
>                         aligned_addr != requested_addr) {
> -               RTE_LOG(WARNING, EAL, "WARNING! Base virtual address hint (%p != %p) not respected!\n",
> -                       requested_addr, aligned_addr);
> -               RTE_LOG(WARNING, EAL, "   This may cause issues with mapping memory into secondary processes\n");
> +               /*
> +                * demote this warning to debug if we did not explicitly request
> +                * a base virtual address.
> +                */
> +               if (internal_conf->base_virtaddr != 0) {
> +                       RTE_LOG(WARNING, EAL, "WARNING! Base virtual address hint (%p != %p) not respected!\n",
> +                               requested_addr, aligned_addr);
> +                       RTE_LOG(WARNING, EAL, "   This may cause issues with mapping memory into secondary processes\n");
> +               } else {
> +                       RTE_LOG(DEBUG, EAL, "WARNING! Base virtual address hint (%p != %p) not respected!\n",
> +                               requested_addr, aligned_addr);
> +                       RTE_LOG(DEBUG, EAL, "   This may cause issues with mapping memory into secondary processes\n");
> +               }
>         } else if (next_baseaddr != NULL) {
>                 next_baseaddr = RTE_PTR_ADD(aligned_addr, *size);
>         }
> --
> 2.17.1
>

EAL options like --in-memory or --no-shconf makes MP unusable.
If we add a rte_mp_disable() for them, we could check here for MP
status here and display nothing at all.
WDYT?
Anatoly Burakov Jan. 22, 2021, 5:21 p.m. UTC | #2
On 09-Nov-20 3:47 PM, Anatoly Burakov wrote:
> Any EAL memory allocation often goes through eal_get_virtual_area()
> function, which will print a warning whenever the resulting allocation
> didn't match the specified address requirements. This is useful for
> when we have requested a specific base virtual address, to let the user
> know that the mapping has deviated from that address.
> 
> However, on Linux, we also have a default base address that's there to
> ensure better chances of successful secondary process initialization,
> as well as higher likelihood of the virtual areas to fit inside the
> IOMMU address width. Because of this default base address, there are
> warnings printed even when no base address was explicitly requested,
> which can be confusing to the user.
> 
> Emit this warning with debug level unless base address was explicitly
> requested by the user.
> 
> Cc: Damjan Marion <damarion@cisco.com>
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> 
> Notes:
>      v2:
>      - Fix the condition to not update the address incorrectly
>      - Instead of removing the warning, let it have debug level unless base address
>        was explicitly specified by the user
>      
>      I'm not entirely sure the trade off between user confusion and helpful debug
>      information is worth it, but in my experience, i've stopped getting any emails
>      about secondary processes a long time ago and this isn't a widely used feature,
>      so i believe this is worth it.

For some reason i didn't get David's comment in my inbox, so i'll copy 
it here:

 > EAL options like --in-memory or --no-shconf makes MP unusable.
 > If we add a rte_mp_disable() for them, we could check here for MP
 > status here and display nothing at all.
 > WDYT?

That sounds like a nice idea, but this patch addresses a different issue.
diff mbox series

Patch

diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
index 33917fa835..1b50c2099d 100644
--- a/lib/librte_eal/common/eal_common_memory.c
+++ b/lib/librte_eal/common/eal_common_memory.c
@@ -140,9 +140,19 @@  eal_get_virtual_area(void *requested_addr, size_t *size,
 		return NULL;
 	} else if (requested_addr != NULL && addr_is_hint &&
 			aligned_addr != requested_addr) {
-		RTE_LOG(WARNING, EAL, "WARNING! Base virtual address hint (%p != %p) not respected!\n",
-			requested_addr, aligned_addr);
-		RTE_LOG(WARNING, EAL, "   This may cause issues with mapping memory into secondary processes\n");
+		/*
+		 * demote this warning to debug if we did not explicitly request
+		 * a base virtual address.
+		 */
+		if (internal_conf->base_virtaddr != 0) {
+			RTE_LOG(WARNING, EAL, "WARNING! Base virtual address hint (%p != %p) not respected!\n",
+				requested_addr, aligned_addr);
+			RTE_LOG(WARNING, EAL, "   This may cause issues with mapping memory into secondary processes\n");
+		} else {
+			RTE_LOG(DEBUG, EAL, "WARNING! Base virtual address hint (%p != %p) not respected!\n",
+				requested_addr, aligned_addr);
+			RTE_LOG(DEBUG, EAL, "   This may cause issues with mapping memory into secondary processes\n");
+		}
 	} else if (next_baseaddr != NULL) {
 		next_baseaddr = RTE_PTR_ADD(aligned_addr, *size);
 	}