diff mbox series

ethdev: fix missing function in map file

Message ID 8e6234ad484ada96596a95eb302caeaed39b9c47.1531473066.git.nelio.laranjeiro@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series ethdev: fix missing function in map file |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Nélio Laranjeiro July 13, 2018, 9:11 a.m. UTC 
Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

--

Changes in v2:

- add missing documentation.
- add missing __rte_experimental in source file.
- update the order in map file.
---
 lib/librte_ethdev/rte_ethdev_version.map | 1 +
 lib/librte_ethdev/rte_flow.c             | 2 +-
 lib/librte_ethdev/rte_flow_driver.h      | 3 ++-
 3 files changed, 4 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon July 13, 2018, 1:54 p.m. UTC | #1 
13/07/2018 11:11, Nelio Laranjeiro:
> Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> --
> 
> Changes in v2:
> 
> - add missing documentation.
> - add missing __rte_experimental in source file.
> - update the order in map file.
> ---
> --- a/lib/librte_ethdev/rte_flow_driver.h
> +++ b/lib/librte_ethdev/rte_flow_driver.h
> @@ -148,6 +148,7 @@ struct rte_flow_expand_rss {
>  /**
>   * Expand RSS flows into several possible flows according to the RSS hash
>   * fields requested and the driver capabilities.
> + * @b EXPERIMENTAL: this API may change without prior notice

Blank line missing to make it appear on a new line.

Applied with following log:
Add rte_flow_expand_rss in map file and tag it as experimental.
diff mbox series

Patch

diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
index 9a0d12d41..38f117f01 100644
--- a/lib/librte_ethdev/rte_ethdev_version.map
+++ b/lib/librte_ethdev/rte_ethdev_version.map
@@ -239,6 +239,7 @@  EXPERIMENTAL {
 	rte_eth_dev_tx_offload_name;
 	rte_eth_switch_domain_alloc;
 	rte_eth_switch_domain_free;
+	rte_flow_expand_rss;
 	rte_mtr_capabilities_get;
 	rte_mtr_create;
 	rte_mtr_destroy;
diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index e06cc2193..cff4b5209 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -531,7 +531,7 @@  rte_flow_copy(struct rte_flow_desc *desc, size_t len,
  * Expand RSS flows into several possible flows according to the RSS hash
  * fields requested and the driver capabilities.
  */
-int
+int __rte_experimental
 rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
 		    const struct rte_flow_item *pattern, uint64_t types,
 		    const struct rte_flow_expand_node graph[],
diff --git a/lib/librte_ethdev/rte_flow_driver.h b/lib/librte_ethdev/rte_flow_driver.h
index ca675f6d3..4d8908226 100644
--- a/lib/librte_ethdev/rte_flow_driver.h
+++ b/lib/librte_ethdev/rte_flow_driver.h
@@ -148,6 +148,7 @@  struct rte_flow_expand_rss {
 /**
  * Expand RSS flows into several possible flows according to the RSS hash
  * fields requested and the driver capabilities.
+ * @b EXPERIMENTAL: this API may change without prior notice
  *
  * @param[out] buf
  *   Buffer to store the result expansion.
@@ -169,7 +170,7 @@  struct rte_flow_expand_rss {
  *
  *   -E2BIG: graph-depth @p graph is too deep.
  */
-int
+int __rte_experimental
 rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
 		    const struct rte_flow_item *pattern, uint64_t types,
 		    const struct rte_flow_expand_node graph[],