[v3,1/2] power: fix power management env detection
Checks
Commit Message
Anything coming from sysfs has a newline at the end. Cut it off before
comparing the strings.
Fixes: 20ab67608a39 ("power: add environment capability probing")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
Notes:
v3:
- Check if last character is really a newline before removing it
v2:
- Fix potential integer underflow
lib/librte_power/power_common.c | 8 ++++++++
1 file changed, 8 insertions(+)
Comments
Tested-by:ma,Lihong<lihongx.ma@intel.com>
Regards,
Ma,lihong
-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Anatoly Burakov
Sent: Tuesday, July 14, 2020 6:30 PM
To: dev@dpdk.org
Cc: Hunt, David <david.hunt@intel.com>; Pattan, Reshma <reshma.pattan@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH v3 1/2] power: fix power management env detection
Anything coming from sysfs has a newline at the end. Cut it off before comparing the strings.
Fixes: 20ab67608a39 ("power: add environment capability probing")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
Notes:
v3:
- Check if last character is really a newline before removing it
v2:
- Fix potential integer underflow
lib/librte_power/power_common.c | 8 ++++++++
1 file changed, 8 insertions(+)
On Tue, Jul 14, 2020 at 11:30:01AM +0100, Anatoly Burakov wrote:
> Anything coming from sysfs has a newline at the end. Cut it off before
> comparing the strings.
>
> Fixes: 20ab67608a39 ("power: add environment capability probing")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: David Hunt <david.hunt@intel.com>
> ---
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
17/07/2020 14:50, Bruce Richardson:
> On Tue, Jul 14, 2020 at 11:30:01AM +0100, Anatoly Burakov wrote:
> > Anything coming from sysfs has a newline at the end. Cut it off before
> > comparing the strings.
> >
> > Fixes: 20ab67608a39 ("power: add environment capability probing")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > Acked-by: David Hunt <david.hunt@intel.com>
> > ---
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
@@ -17,6 +17,7 @@ cpufreq_check_scaling_driver(const char *driver_name)
unsigned int lcore_id = 0; /* always check core 0 */
char fullpath[PATH_MAX];
char readbuf[PATH_MAX];
+ size_t end_idx;
char *s;
FILE *f;
@@ -39,6 +40,13 @@ cpufreq_check_scaling_driver(const char *driver_name)
if (s == NULL)
return 0;
+ /* when read from sysfs, driver name has an extra newline at the end */
+ end_idx = strnlen(readbuf, sizeof(readbuf));
+ if (end_idx > 0 && readbuf[end_idx - 1] == '\n') {
+ end_idx--;
+ readbuf[end_idx] = '\0';
+ }
+
/* does the driver name match? */
if (strncmp(readbuf, driver_name, sizeof(readbuf)) != 0)
return 0;