diff mbox

[dpdk-dev,10/13] cxgbe: fix check to close other ports properly

Message ID 7d9ab1f90260a01b7ea021579a57c2a044748b33.1520720053.git.rahul.lakkireddy@chelsio.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Rahul Lakkireddy March 10, 2018, 10:48 p.m. UTC 
  Fixes: 084b35314ff2 ("net/cxgbe: rework ethdev device allocation")
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
---
 drivers/net/cxgbe/cxgbe_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit March 28, 2018, 5:24 p.m. UTC | #1 
On 3/10/2018 10:48 PM, Rahul Lakkireddy wrote:
> Fixes: 084b35314ff2 ("net/cxgbe: rework ethdev device allocation")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>

Squashed into relevant commit in next-net, thanks.
diff mbox

Patch

diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c
index 882bcb7ef..b3b2b006a 100644
--- a/drivers/net/cxgbe/cxgbe_main.c
+++ b/drivers/net/cxgbe/cxgbe_main.c
@@ -1246,7 +1246,7 @@  void cxgbe_close(struct adapter *adapter)
 					   adapter->pf, 0, pi->viid);
 			rte_free(pi->eth_dev->data->mac_addrs);
 			/* Skip first port since it'll be freed by DPDK stack */
-			if (!i) {
+			if (i) {
 				rte_free(pi->eth_dev->data->dev_private);
 				rte_eth_dev_release_port(pi->eth_dev);
 			}