| Message ID | 7F861DC0615E0C47A872E6F3C5FCDDBD05DCB8C6@BPXM14GP.gisp.nec.co.jp (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 06B1168CD; Thu, 4 Dec 2014 00:34:18 +0100 (CET) Received: from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [210.143.35.52]) by dpdk.org (Postfix) with ESMTP id 0344F559C for <dev@dpdk.org>; Thu, 4 Dec 2014 00:34:16 +0100 (CET) Received: from mailgate3.nec.co.jp ([10.7.69.193]) by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id sB3NYECN013498 for <dev@dpdk.org>; Thu, 4 Dec 2014 08:34:14 +0900 (JST) Received: from mailsv3.nec.co.jp (imss62.nec.co.jp [10.7.69.157]) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP id sB3NYDG01239 for <dev@dpdk.org>; Thu, 4 Dec 2014 08:34:13 +0900 (JST) Received: from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7]) by mailsv3.nec.co.jp (8.13.8/8.13.4) with ESMTP id sB3NYD7n000309 for <dev@dpdk.org>; Thu, 4 Dec 2014 08:34:13 +0900 (JST) Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.142] [10.38.151.142]) by mail03.kamome.nec.co.jp with ESMTP id BT-MMP-334413; Thu, 4 Dec 2014 08:33:55 +0900 Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.73]) by BPXC14GP.gisp.nec.co.jp ([10.38.151.142]) with mapi id 14.03.0174.002; Thu, 4 Dec 2014 08:33:54 +0900 From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> To: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH] mk: fix LDFLAGS for shared lib Thread-Index: AdAPUXZ7rm6VYiryQ02Oy4YIP6UZAQ== Date: Wed, 3 Dec 2014 23:33:54 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05DCB8C6@BPXM14GP.gisp.nec.co.jp> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: Hayato Momma <h-momma@ce.jp.nec.com> Subject: [dpdk-dev] [PATCH] mk: fix LDFLAGS for shared lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Hiroshi Shimamoto
Dec. 3, 2014, 11:33 p.m. UTC
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> Only CPU_LDFLAGS is used in mk/rte.sharelib.mk. It should be LDFLAGS to build the library with correct linkage options. Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com> --- mk/rte.sharelib.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk. > It should be LDFLAGS to build the library with correct linkage options. > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com> > > --- > mk/rte.sharelib.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk > index c0a811a..df6c268 100644 > --- a/mk/rte.sharelib.mk > +++ b/mk/rte.sharelib.mk > @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE > > OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o) > > -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight > O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") > O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)" Does this continue to work on cross compiled arches (32 bit on 64 bit systems and vice versa)? I have this recollection that something in CPU_LDFLAGS was needed Neil
> Subject: Re: [dpdk-dev] mk: fix LDFLAGS for shared lib > > On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > > > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk. > > It should be LDFLAGS to build the library with correct linkage options. > > > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com> > > > > --- > > mk/rte.sharelib.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk > > index c0a811a..df6c268 100644 > > --- a/mk/rte.sharelib.mk > > +++ b/mk/rte.sharelib.mk > > @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE > > > > OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o) > > > > -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight > > O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") > > O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)" > > Does this continue to work on cross compiled arches (32 bit on 64 bit systems > and vice versa)? I have this recollection that something in CPU_LDFLAGS was > needed yes, LDFLAGS must contain CPU_LDFLAGS. mk/target/generic/rte.vars.mk:# merge all LDFLAGS mk/target/generic/rte.vars.mk:LDFLAGS := $(CPU_LDFLAGS) $(EXECENV_LDFLAGS) $(TOOLCHAIN_LDFLAGS) $(MACHINE_LDFLAGS) mk/target/generic/rte.vars.mk:LDFLAGS += $(TARGET_LDFLAGS) thanks, Hiroshi > Neil
2014-12-08 23:44, Hiroshi Shimamoto: > > On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote: > > > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > > > > > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk. > > > It should be LDFLAGS to build the library with correct linkage options. > > > > > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > > Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com> > > > > > > --- > > > mk/rte.sharelib.mk | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk > > > index c0a811a..df6c268 100644 > > > --- a/mk/rte.sharelib.mk > > > +++ b/mk/rte.sharelib.mk > > > @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE > > > > > > OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o) > > > > > > -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > > +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > > O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight > > > O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") > > > O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)" > > > > Does this continue to work on cross compiled arches (32 bit on 64 bit systems > > and vice versa)? I have this recollection that something in CPU_LDFLAGS was > > needed > > yes, LDFLAGS must contain CPU_LDFLAGS. > > mk/target/generic/rte.vars.mk:# merge all LDFLAGS > mk/target/generic/rte.vars.mk:LDFLAGS := $(CPU_LDFLAGS) $(EXECENV_LDFLAGS) $(TOOLCHAIN_LDFLAGS) $(MACHINE_LDFLAGS) > mk/target/generic/rte.vars.mk:LDFLAGS += $(TARGET_LDFLAGS) Applied Thanks
diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk index c0a811a..df6c268 100644 --- a/mk/rte.sharelib.mk +++ b/mk/rte.sharelib.mk @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o) -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)"