From patchwork Wed Mar 15 13:35:44 2017
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Ferruh Yigit <ferruh.yigit@intel.com>
X-Patchwork-Id: 21793
Return-Path: <dev-bounces@dpdk.org>
X-Original-To: patchwork@dpdk.org
Delivered-To: patchwork@dpdk.org
Received: from [92.243.14.124] (localhost [IPv6:::1])
	by dpdk.org (Postfix) with ESMTP id 17EF928F3;
	Wed, 15 Mar 2017 14:35:50 +0100 (CET)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
	by dpdk.org (Postfix) with ESMTP id 5B8F0214A
	for <dev@dpdk.org>; Wed, 15 Mar 2017 14:35:46 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
	by orsmga105.jf.intel.com with ESMTP; 15 Mar 2017 06:35:45 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos; i="5.36,168,1486454400"; d="scan'208";
	a="1122852034"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122])
	([10.237.220.122])
	by fmsmga001.fm.intel.com with ESMTP; 15 Mar 2017 06:35:44 -0700
To: Pascal Mazon <pascal.mazon@6wind.com>, keith.wiles@intel.com
References: <1488904298-31395-1-git-send-email-pascal.mazon@6wind.com>
	<cover.1489479553.git.pascal.mazon@6wind.com>
	<972357ac96dcfa64ecd30bb2350f8282b858af03.1489479553.git.pascal.mazon@6wind.com>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <725e6ac6-acc5-7adc-02a7-f1a6bf79f7bd@intel.com>
Date: Wed, 15 Mar 2017 13:35:44 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
	Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: 
 <972357ac96dcfa64ecd30bb2350f8282b858af03.1489479553.git.pascal.mazon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v4 7/8] net/tap: add packet type management
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
	<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
	<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/14/2017 8:22 AM, Pascal Mazon wrote:
> Advertize packet types supported by the librte_net.
> 
> Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>

<...>

>  
>  #include <sys/types.h>
>  #include <sys/stat.h>
> @@ -228,6 +229,8 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
>  		mbuf->data_len = len;
>  		mbuf->pkt_len = len;
>  		mbuf->port = rxq->in_port;
> +		mbuf->packet_type = rte_net_get_ptype(mbuf, NULL,
> +						      RTE_PTYPE_ALL_MASK);

This breaks shared library build [1], now librte_net also needs to be
linked against PMD, this can be done easily by adding library as
dependency [2] to PMD.


[1]
rte_eth_tap.o: In function `pmd_rx_burst':
.../drivers/net/tap/rte_eth_tap.c:(.text+0x863): undefined reference to
`rte_net_get_ptype'


[2]

--- a/drivers/net/tap/Makefile
+++ b/drivers/net/tap/Makefile
@@ -53,5 +53,6 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += lib/librte_mbuf
 DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += lib/librte_mempool
 DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += lib/librte_ether
 DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += lib/librte_kvargs
+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += lib/librte_net

 include $(RTE_SDK)/mk/rte.lib.mk