From patchwork Mon Oct 23 14:49:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 30723 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 281281B66A; Mon, 23 Oct 2017 16:50:33 +0200 (CEST) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 801161B64B for ; Mon, 23 Oct 2017 16:50:19 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id b189so10001425wmd.4 for ; Mon, 23 Oct 2017 07:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=CekIAUTC62nPJCxBHz4VgqHz8D6AZKA+Tt2/TqB9K9I=; b=xyL/PyUBg49jNM6+kloxIH+pGe6oomuWJEsrI1e6V53yFHqQWJRrU3uYEd32OpEfYh k8JkluoLFlJ+cOGqwj8hdHYySRyskr5Z003uczcfo9BE+D9uby8oMS/ZCyFQaengXZMD RPZDnfu9Ll/la4w/QkaQUXW2aqYM6mxIs5Vyf4hak4LxkSnwlViXk8ozVa111qrktvCf OYxmihrCg5p4THTm0m7yArgxkGWu5j8cwBlyV7Kk1Oj3h+U3l1t4cPAF31jNYgVK//Sd bPqK1lGa2SrNdaYKfvGqhgftqyNwEsC2j5rvY2/LpwG3uSoJV+x7IhAPXLJYL+hjp0Pc Mogg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=CekIAUTC62nPJCxBHz4VgqHz8D6AZKA+Tt2/TqB9K9I=; b=KHVbcO6ToUbErvH8jewPDFMN92qBaYVXvvPTS4v4883mUs1hNnHZqXV75UeyxGgQ2f GY7TH8/3Ai60Wr8fNd/lJz9z2oar37PeG7XpGW/Nl0YXWWzuSBdJ1stweR+j+uN9Hl97 q/2yXsw5gDg2ULNKgJqC44noWeQt34qrDZJuv0kvsmb82k2gCoXtT4FMEpgq2+Gzv4m+ XiW/Kth+shqdgrtVIFQBKoJi0AcHa/Y2TkNmIV1/ZpHLwcNrkiiTFbP5RigVilBhDFDf wiJcy8SUdCSpMKcC+fFKSwAMbpXif/2w7tmT+DZM9z7CddMH7BVbFczcmJ4LfOh2EfoH M52g== X-Gm-Message-State: AMCzsaU+CeeyVA6T9A/WdlVK3pytCMQfzsmhRj2bdEjC3mWjb8xPNY8v qG9bw6Zk1iEE6MahGD8Zg2eRoSBZSA== X-Google-Smtp-Source: ABhQp+Qdw4KoNq2PbDXBoBg3o/RNCpiU5GIGIu19/cW/Y0sDxPjW4rRbwvxNpngnHURVQ97DDrQPiw== X-Received: by 10.28.22.66 with SMTP id 63mr5691147wmw.11.1508770218931; Mon, 23 Oct 2017 07:50:18 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s196sm4908234wmb.26.2017.10.23.07.50.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Oct 2017 07:50:18 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil Date: Mon, 23 Oct 2017 16:49:57 +0200 Message-Id: <6cb4fb2594073f91702b710a65feebb13a3dc427.1508768946.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 7/7] net/mlx5: fix flow director flow add X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Flows are added by priv_flow_create() in the associated list, adding them a second time corrupts the list causing an infinite loop when parsing it. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 13b78ce9b..26cf593af 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -2792,7 +2792,6 @@ priv_fdir_filter_add(struct priv *priv, attributes.actions, &error); if (flow) { - TAILQ_INSERT_TAIL(&priv->flows, flow, next); DEBUG("FDIR created %p", (void *)flow); return 0; }