From patchwork Mon Dec 4 06:38:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt X-Patchwork-Id: 31903 X-Patchwork-Delegate: helin.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D17C52A5D; Mon, 4 Dec 2017 07:39:19 +0100 (CET) Received: from zyc-PC.local (unknown [119.61.11.228]) by dpdk.org (Postfix) with SMTP id 08E482661 for ; Mon, 4 Dec 2017 07:39:16 +0100 (CET) Date: Mon, 4 Dec 2017 14:38:09 +0800 From: zhouyangchao CC: qi.z.zhang@intel.com; To: dev@dpdk.org; Message-ID: <6ac145b7-23c5-4741-95a7-e3ebc072ad6e@zyc-PC.local> X-Mailer: TortoiseGit MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" FM10K HW does not have such restrictions. Enabling RSS with single queue is not used to distribute flow but to compute a RSS hash value. It can reduce cpu cycles of computing a hash value with five tuples. In addition, there is an explicit method to disable RSS instead of an obscure way. Signed-off-by: Yangchao Zhou --- drivers/net/fm10k/fm10k_ethdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 2d05a46..403f6c5 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -533,9 +533,8 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev) 0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA, }; - if (dev->data->nb_rx_queues == 1 || - dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS || - dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) { + if (dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS || + dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) { FM10K_WRITE_REG(hw, FM10K_MRQC(0), 0); return; }