From patchwork Tue Jan 31 16:02:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 20098 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 5A2BA5A44; Tue, 31 Jan 2017 17:04:12 +0100 (CET) Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 3AA7FDE3 for ; Tue, 31 Jan 2017 17:03:49 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id c85so267152681wmi.1 for ; Tue, 31 Jan 2017 08:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=icxHBeASnlObhIVeaYNhykZ/h77ddZ6RpbTtbkcjncM=; b=Zje7Bb99PwK9bBwN0AQV5H5/m7yywtAq2RGtDv0CWp0o2MmgEpmW/mpqoDfiVsy33f pKLqAWN2q1gbP2xVSbMXf+IKA+1bxRZX2A8VPMbqcCmE9AFaT2l9MJvB7TqoGKSDDYpm mrClNd9+PyqHLqAKl5BfbFvqfH2c0k3qC6h2wzzzaPhoNd9ZCj9Xdd9DwVp/kzC1Yvhz M8TD8AfqAN4Yi9OlcICbu38JeVU40SIjy8A+raj8fUVxS2kQsjSnd58X7USD1JH3Tc+5 6FvtOlB7xB2kqIPbQ4n/t9z05wKr8Q9U9Awnb20ZhbriT9BedpsTpGZirfB/in8xon/1 TsvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=icxHBeASnlObhIVeaYNhykZ/h77ddZ6RpbTtbkcjncM=; b=DpaLoNUHHYm6umB6XivfJP3tl1zEXOnAn9TLHMn1vSw4Jzy1+3M1Xsspt6hgE8XJtZ DhxIgjYxELJdqowC7ua+WolfgSq/GbZDS5frQhj3LJiIivoJntau5/m6v5hTGjGnppRp +NVPblcvKi2ZCkt91F4nDbo7IE4VLai5Wx2+EK3f7v39/Oxd5JCeMHN5FFifbOFsTs6X HiGlAkDn4DT3wnK0i0m7WAH9mBKp/kBmON1Br4K1SZxVIvTj6aJiLcYnw/a4vWYvO0gc XcwgrLVctBulqvcZsbq4K1N0QZUUSR8Hl7YcCW6DRCKHP0bbUJ5kCw72OvoZA+EhQbcZ jFCw== X-Gm-Message-State: AIkVDXJwzfMdhv86EHDYwI02EuIoISYE7RIVo60YPU4udZPE80xw8DdWPSr20lnJXwKsFF4/ X-Received: by 10.223.135.201 with SMTP id c9mr24058202wrc.139.1485878628936; Tue, 31 Jan 2017 08:03:48 -0800 (PST) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 33sm29010127wrd.34.2017.01.31.08.03.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 31 Jan 2017 08:03:48 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil Date: Tue, 31 Jan 2017 17:02:47 +0100 Message-Id: <6781e89c0572de09a4c8b029d45168296d818a93.1485878361.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <8772a5838ed3733da6749b333375e2a6aa6ea2ad.1485878361.git.nelio.laranjeiro@6wind.com> References: <8772a5838ed3733da6749b333375e2a6aa6ea2ad.1485878361.git.nelio.laranjeiro@6wind.com> In-Reply-To: <8772a5838ed3733da6749b333375e2a6aa6ea2ad.1485878361.git.nelio.laranjeiro@6wind.com> References: <8772a5838ed3733da6749b333375e2a6aa6ea2ad.1485878361.git.nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH 2/3] net/mlx5: fix verification of mark action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A configuration structure for the MARK action must always be specified. Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 4917f79..34ac5d3 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -457,7 +457,13 @@ priv_flow_validate(struct priv *priv, (const struct rte_flow_action_mark *) actions->conf; - if (mark && (mark->id >= MLX5_FLOW_MARK_MAX)) { + if (!mark) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "mark must be defined"); + return -rte_errno; + } else if (mark->id >= MLX5_FLOW_MARK_MAX) { rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, actions,