diff mbox

[dpdk-dev] eal/ipc: fix missing ignore message name

Message ID 648478c5ff8bcbe49306d96022eef1f89c7a935a.1523634914.git.anatoly.burakov@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Anatoly Burakov April 13, 2018, 3:55 p.m. UTC 
  We are trying to notify sender that response from current process
should be ignored, but we didn't specify which request this response
was for. Fix by copying request name from the original message.

Fixes: 579a4ccc345c ("eal: ignore IPC messages until init is complete")
Cc: anatoly.burakov@intel.com

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_eal/common/eal_common_proc.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jianfeng Tan April 13, 2018, 4:16 p.m. UTC | #1 
On 4/13/2018 11:55 PM, Anatoly Burakov wrote:
> We are trying to notify sender that response from current process
> should be ignored, but we didn't specify which request this response
> was for. Fix by copying request name from the original message.
>
> Fixes: 579a4ccc345c ("eal: ignore IPC messages until init is complete")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>

> ---
>   lib/librte_eal/common/eal_common_proc.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
> index 2d3bda3..5c2acd4 100644
> --- a/lib/librte_eal/common/eal_common_proc.c
> +++ b/lib/librte_eal/common/eal_common_proc.c
> @@ -323,6 +323,8 @@ process_msg(struct mp_msg_internal *m, struct sockaddr_un *s)
>   			 */
>   			struct rte_mp_msg dummy;
>   			memset(&dummy, 0, sizeof(dummy));
> +			snprintf(dummy.name, sizeof(dummy.name),
> +					"%s", msg->name);
>   			mp_send(&dummy, s->sun_path, MP_IGN);
>   		} else {
>   			RTE_LOG(ERR, EAL, "Cannot find action: %s\n",
Thomas Monjalon April 16, 2018, 11:28 p.m. UTC | #2 
13/04/2018 18:16, Tan, Jianfeng:
> 
> On 4/13/2018 11:55 PM, Anatoly Burakov wrote:
> > We are trying to notify sender that response from current process
> > should be ignored, but we didn't specify which request this response
> > was for. Fix by copying request name from the original message.
> >
> > Fixes: 579a4ccc345c ("eal: ignore IPC messages until init is complete")
> > Cc: anatoly.burakov@intel.com
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index 2d3bda3..5c2acd4 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -323,6 +323,8 @@  process_msg(struct mp_msg_internal *m, struct sockaddr_un *s)
 			 */
 			struct rte_mp_msg dummy;
 			memset(&dummy, 0, sizeof(dummy));
+			snprintf(dummy.name, sizeof(dummy.name),
+					"%s", msg->name);
 			mp_send(&dummy, s->sun_path, MP_IGN);
 		} else {
 			RTE_LOG(ERR, EAL, "Cannot find action: %s\n",