From patchwork Mon May 30 15:49:55 2016
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: Ferruh Yigit <ferruh.yigit@intel.com>
X-Patchwork-Id: 13108
X-Patchwork-Delegate: thomas@monjalon.net
Return-Path: <dev-bounces@dpdk.org>
X-Original-To: patchwork@dpdk.org
Delivered-To: patchwork@dpdk.org
Received: from [92.243.14.124] (localhost [IPv6:::1])
	by dpdk.org (Postfix) with ESMTP id CF7655958;
	Mon, 30 May 2016 17:50:00 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
	by dpdk.org (Postfix) with ESMTP id 711DB2E8E
	for <dev@dpdk.org>; Mon, 30 May 2016 17:49:58 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
	by fmsmga104.fm.intel.com with ESMTP; 30 May 2016 08:49:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,390,1459839600"; d="scan'208";a="112930061"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.33])
	([10.237.221.33])
	by fmsmga004.fm.intel.com with ESMTP; 30 May 2016 08:49:56 -0700
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
References: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com>
Cc: thomas.monjalon@6wind.com, helin.zhang@intel.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <574C6123.5090005@intel.com>
Date: Mon, 30 May 2016 16:49:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
	Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] kni: fix use of undefined comma variable in
	makefile
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
	<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
	<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/30/2016 12:56 PM, Olivier Matz wrote:
> The $(comma) variable is not defined in this Makefile, nor in
> any included Makefile. Seen while doing a "make clean" on ubuntu:
> 
>   $ make clean
>   == Clean lib
>   == Clean lib/librte_compat
>   == Clean lib/librte_eal
>   == Clean lib/librte_eal/common
>   == Clean lib/librte_eal/linuxapp
>   == Clean lib/librte_eal/linuxapp/eal
>   == Clean lib/librte_eal/linuxapp/igb_uio
>   == Clean lib/librte_eal/linuxapp/kni
>   tr: missing operand after ‘.-’
>   Two strings must be given when translating.
>   Try 'tr --help' for more information.

I don't observe this error on Ubuntu.

Also did a quick check and $(comma) seems defined, but not sure exactly
where. What I test:

$ lsb_release -si
Ubuntu


$ git diff


$ make -C lib/librte_eal/linuxapp/kni test_comma
make: Entering directory '.../dpdk/lib/librte_eal/linuxapp/kni'
= comma: , =
make: Leaving directory '.../dpdk/lib/librte_eal/linuxapp/kni'

diff --git a/lib/librte_eal/linuxapp/kni/Makefile
b/lib/librte_eal/linuxapp/kni/Makefile
index ac99d3f..dcad241 100644
--- a/lib/librte_eal/linuxapp/kni/Makefile
+++ b/lib/librte_eal/linuxapp/kni/Makefile
@@ -90,4 +90,7 @@ SRCS-y += kni_net.c
 SRCS-y += kni_ethtool.c
 SRCS-$(CONFIG_RTE_KNI_VHOST) += kni_vhost.c

+test_comma:
+       @echo "= comma: $(comma) ="
+