From patchwork Mon Apr 25 09:05:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tetsuya Mukawa X-Patchwork-Id: 12221 X-Patchwork-Delegate: yuanhan.liu@linux.intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 3E9152946; Mon, 25 Apr 2016 11:05:34 +0200 (CEST) Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id DCF2828F2 for ; Mon, 25 Apr 2016 11:05:32 +0200 (CEST) Received: by mail-pa0-f44.google.com with SMTP id zm5so62356006pac.0 for ; Mon, 25 Apr 2016 02:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=9ZLKrNnrxRWGS1vfVRgpigZGB6ik61nvXrMCB9y38FE=; b=0w9uyY24p37c5wCAwMBR4SPEtyuLKrq7rglurYUe2YA155g2XmkOWjH81ucgfHZTMq ySh9fFaevlkrvJhKdl35/ZnfjBMFZp8kMVXTFgIAaERohCSxYyxn6NmDc6yCtAFAQDEI jVHCYJITz99xA+8j7DcQnc/T8e0zwl0SuGxtz5SHJ/FaHk0PLXx3MAgCQuniMI7oR2fE d4bwJpN5Jkm08YO7ttHnJB1fCoolGtEt/I0tvOyx02JDe9MVNKdkU8aexSZpNMEdZLHW Jqn7qQTmfdboYWJdHvbJ4jSsBH2HF8Tl1VV2V6jBsEGA8gkGnrhT6TStel+NhicfQOTN LjpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=9ZLKrNnrxRWGS1vfVRgpigZGB6ik61nvXrMCB9y38FE=; b=QgpT5gF7QJhafB2kWmfrQB9kKBuCl+JT1TumdwPsuL6TjB7fiJUjU/qFz+JFfon7n/ tfI/L9HEhjB1MbQAryMIZnHLHEmmVIPXqCdyNgN4rCHpg49tyD9DIpAEChSJoAtGn6sH 7+kSiOZYv6j11LXtIEzdsc1Zk12+wNsMeOh5RD4pwZDnAZT8gxqm9SzE2p6yJvkvaYSo 1ns9FhO2R6TA00pP28QcO0h60ofY/mIItO6TzVmUuHGRynZy1AP2+9zACGAyuehVISEs E5LXyxSmxlnDpUj0W9gd9gW07BRepGDNYhx3DIb+OMS0HweUN9xvp3AiMsDTB+rcM0cV D5hA== X-Gm-Message-State: AOPr4FX+TpnTw4flGuQmOBdGUjeFUxpFt6a9GrDWzBG5gh58Swqqy+cIDY3iXfqIW3QMJw== X-Received: by 10.66.78.73 with SMTP id z9mr46860453paw.4.1461575132095; Mon, 25 Apr 2016 02:05:32 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id lq10sm27972838pab.36.2016.04.25.02.05.30 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 25 Apr 2016 02:05:30 -0700 (PDT) From: Tetsuya Mukawa To: "dev@dpdk.org" , Yuanhan Liu Cc: "Xie, Huawei" Message-ID: <571DDDD8.6000000@igel.co.jp> Date: Mon, 25 Apr 2016 18:05:28 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 Subject: [dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Yuanhan, I want to apply a patch to vhost PMD. Before submitting, could you please let me know your guess about the patch? Here is my problem. I am using below shared library configuration to build my application. CONFIG_RTE_BUILD_SHARED_LIB=y Normally, My application doesn't need vhost facilities, so librte_vhost isn't linked while compiling. Sometimes, I need to use vhost PMD, so I just want to add '-d librte_pmd_vhost.so' to DPDK command line to load vhost PMD library. But my application doesn't have librte_vhost, then I've got an error about it. Even if specify like "-d librte_vhost -d librte_pmd_vhost", I still have an error. Probably this is because above libraries will be dlopen(ed) with RTLD_LOCAL option. Here, I have 2 choices. One is linking librte_vhost to my application while compiling, even if I don't need it normally. This is the way all DPDK examples did. But I am wondering if I should follow this. Another way is applying a below patch. This is same way to link libpcap to librte_pmd_pcap. What do you think about adding it to vhost PMD? Thanks, Tetsuya Acked-by: Panu Matilainen --- a/drivers/net/vhost/Makefile +++ b/drivers/net/vhost/Makefile @@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) +LDLIBS += -lrte_vhost EXPORT_MAP := rte_pmd_vhost_version.map