From patchwork Thu Mar 24 06:54:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Panu Matilainen X-Patchwork-Id: 11690 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 159AD2BF2; Thu, 24 Mar 2016 07:54:35 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6D5812BD7 for ; Thu, 24 Mar 2016 07:54:33 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 9ABC2804E4; Thu, 24 Mar 2016 06:54:32 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-151.ams2.redhat.com [10.36.4.151]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2O6sUG6031228; Thu, 24 Mar 2016 02:54:31 -0400 To: "Lu, Wenzhuo" , Thomas Monjalon References: <1458682638-28378-1-git-send-email-aconole@redhat.com> <1458682638-28378-3-git-send-email-aconole@redhat.com> <5248499.WRMHcbhMjp@xps13> <1470283.VAKgtTzWav@xps13> <6A0DE07E22DDAD4C9103DF62FEBC09090343E973@shsmsx102.ccr.corp.intel.com> Cc: Aaron Conole , "dev@dpdk.org" , "Richardson, Bruce" From: Panu Matilainen Message-ID: <56F38F26.1030707@redhat.com> Date: Thu, 24 Mar 2016 08:54:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090343E973@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Subject: Re: [dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/24/2016 02:35 AM, Lu, Wenzhuo wrote: > Hi Thomas, Aaron, >>> Wenzhuo, do you agree to fix the base driver here? > Honestly I find the logic has some problem and maybe more changes needed. I'm talking with our kernel driver contactors to make sure they have no concern about my idea. > And Aaron, do we really need to fix this code? For I find this function is not called. So it has no real impact to us. Could we just wait until kernel driver fixes it and leverage the new version? Thanks. It breaks the build with gcc >= 6.0 due to -Werror so yes we need to fix it, one way or the other. As spelled out in an earlier mail (http://dpdk.org/ml/archives/dev/2016-March/034290.html), for somebody building with gcc >= 6.0 the options basically are: 1) disable the driver entirely 2) build with -Wno-error 3) paper over it with local warning disablers 4) patch the thing locally If the offending function really is not used at all in DPDK context then 3) is an entirely valid option for an upstream solution, ie something like (untested) - Panu - --- a/drivers/net/e1000/Makefile +++ b/drivers/net/e1000/Makefile @@ -54,6 +54,9 @@ else # CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter CFLAGS_BASE_DRIVER += -Wno-unused-variable +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation +endif endif #