From patchwork Mon Dec 7 08:33:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Panu Matilainen X-Patchwork-Id: 9379 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 1DCC19589; Mon, 7 Dec 2015 09:33:29 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 717339582 for ; Mon, 7 Dec 2015 09:33:28 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id A6238A92; Mon, 7 Dec 2015 08:33:27 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-85.ams2.redhat.com [10.36.5.85]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB78XPjp031036; Mon, 7 Dec 2015 03:33:25 -0500 To: Thomas Monjalon , =?UTF-8?Q?Simon_K=c3=a5gstr=c3=b6m?= References: <20151124085001.58817bf0@miho> <56614AE8.2010200@netinsight.net> <566167CC.3040303@6wind.com> <4623746.AUJoGgWqRB@xps13> From: Panu Matilainen Message-ID: <56654454.3040508@redhat.com> Date: Mon, 7 Dec 2015 10:33:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <4623746.AUJoGgWqRB@xps13> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] mk: pass EXTRA_CFLAGS to AUTO_CPUFLAGS to enable local modifications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/04/2015 08:53 PM, Thomas Monjalon wrote: >>>> We have encountered a CPU where the AES-NI instruction set is disabled >>>> due to export restrictions. Since the build machine and target machine >>>> is different, using -native configs doesn't work, and on this CPU, the >>>> application refuses to run due to the AES CPU flags being amiss. >>>> >>>> The patch passes EXTRA_CFLAGS to the figure-out-cpu-flags helper, >>>> which allows us to add -mno-aes to the compile flags and resolve this >>>> problem. >>>> >>>> Signed-off-by: Simon Kagstrom >> >> Acked-by: Olivier Matz > > Applied, thanks > This causes some complications on Fedora/RHEL due to fairly complex interactions with -Werror, -Wall and -Wformat-security mixup between upstream- and distro default compiler flags. More specifically, when EXTRA_CFLAGS contains warning flag manipulation this patch can cause mismatch between other options that are okay elsewhere in dpdk make. A simple fix is to pass WERROR_FLAGS to AUTO_CPUFLAGS too to counter this, ie I can send an official patch if this seems acceptable. - Panu - diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index c6bb8de..28f203b 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk @@ -33,7 +33,7 @@ # used to set the RTE_CPUFLAG_* environment variables giving details # of what instruction sets the target cpu supports. -AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null) +AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(WERROR_FLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null) # adding flags to CPUFLAGS