From patchwork Wed Jun 17 08:10:56 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Panu Matilainen <pmatilai@redhat.com>
X-Patchwork-Id: 5465
Return-Path: <dev-bounces@dpdk.org>
X-Original-To: patchwork@dpdk.org
Delivered-To: patchwork@dpdk.org
Received: from [92.243.14.124] (localhost [IPv6:::1])
	by dpdk.org (Postfix) with ESMTP id 7DC16C3CE;
	Wed, 17 Jun 2015 10:11:00 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
	by dpdk.org (Postfix) with ESMTP id 82452C3CC
	for <dev@dpdk.org>; Wed, 17 Jun 2015 10:10:58 +0200 (CEST)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id BB5AD370232;
	Wed, 17 Jun 2015 08:10:57 +0000 (UTC)
Received: from localhost.localdomain (vpn1-5-32.ams2.redhat.com [10.36.5.32])
	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with
	ESMTP id t5H8Aup1030539; Wed, 17 Jun 2015 04:10:56 -0400
Message-ID: <55812B90.9030409@redhat.com>
Date: Wed, 17 Jun 2015 11:10:56 +0300
From: Panu Matilainen <pmatilai@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: "Xie, Huawei" <huawei.xie@intel.com>,
	"Loftus, Ciara" <ciara.loftus@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1433209800-29091-1-git-send-email-huawei.xie@intel.com>
	<1433474786-704-1-git-send-email-huawei.xie@intel.com>
	<74F120C019F4A64C9B78E802F6AD4CC220567AC8@IRSMSX106.ger.corp.intel.com>
	<C37D651A908B024F974696C65296B57B0F4F2676@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: 
 <C37D651A908B024F974696C65296B57B0F4F2676@SHSMSX101.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
Subject: Re: [dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister
	vhost unix domain socket
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
	<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
	<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 06/08/2015 06:38 PM, Xie, Huawei wrote:
> On 6/5/2015 5:04 PM, Loftus, Ciara wrote:
>>
>>> -----Original Message-----
>>> From: Xie, Huawei
>>> Sent: Friday, June 05, 2015 4:26 AM
>>> To: dev@dpdk.org
>>> Cc: Loftus, Ciara; Xie, Huawei; Sun, Peng A
>>> Subject: [PATCH v2] vhost: provide vhost API to unregister vhost unix domain
>>> socket
>>>
>>> rte_vhost_driver_unregister will remove the listenfd from event list, and
>>> then close it.
>>>
>>> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
>>> Signed-off-by: Peng Sun <peng.a.sun@intel.com>
>>> ---
>>>   lib/librte_vhost/rte_virtio_net.h            |  3 ++
>>>   lib/librte_vhost/vhost_cuse/vhost-net-cdev.c |  9 ++++
>>>   lib/librte_vhost/vhost_user/vhost-net-user.c | 68
>>> +++++++++++++++++++++++-----
>>>   lib/librte_vhost/vhost_user/vhost-net-user.h |  2 +-
>>>   4 files changed, 69 insertions(+), 13 deletions(-)
>>>

You need to update the symbol version map when adding new public APIs. 
Something like:


	- Panu -

--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/lib/librte_vhost/rte_vhost_version.map
@@ -13,3 +13,11 @@ DPDK_2.0 {

         local: *;
  };
+
+DPDK_2.1 {
+       global:
+
+       rte_vhost_driver_unregister;
+
+       local: *;
+};