From patchwork Thu Feb 12 13:58:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Panu Matilainen X-Patchwork-Id: 3229 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E6EEFADC3; Thu, 12 Feb 2015 14:58:10 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2CE90ADC2 for ; Thu, 12 Feb 2015 14:58:10 +0100 (CET) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1CDw9PF028295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 12 Feb 2015 08:58:09 -0500 Received: from localhost.localdomain (vpn1-5-97.ams2.redhat.com [10.36.5.97]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1CDw7ld003153; Thu, 12 Feb 2015 08:58:08 -0500 Message-ID: <54DCB16F.7080104@redhat.com> Date: Thu, 12 Feb 2015 15:58:07 +0200 From: Panu Matilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bruce Richardson References: <09445d1715453b2eff4399da998717b967b829b3.1423739602.git.pmatilai@redhat.com> <20150212112518.GB10216@bricha3-MOBL3> <54DC964B.3050709@redhat.com> <20150212120834.GC10216@bricha3-MOBL3> In-Reply-To: <20150212120834.GC10216@bricha3-MOBL3> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Make -Werror optional X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/12/2015 02:08 PM, Bruce Richardson wrote: > On Thu, Feb 12, 2015 at 02:02:19PM +0200, Panu Matilainen wrote: >> On 02/12/2015 01:25 PM, Bruce Richardson wrote: >>> On Thu, Feb 12, 2015 at 01:13:22PM +0200, Panu Matilainen wrote: >>>> This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable >>>> fail-on-warning compile behavior, defaulting to off. >>>> >>>> Failing build on warnings is a useful developer tool but its bad >>>> for release tarballs which can and do get built with newer >>>> compilers than what was used/available during development. Compilers >>>> routinely add new warnings so code which built silently with cc X >>>> might no longer do so with X+1. This doesn't make the existing code >>>> any more buggier and failing the build in this case does not help >>>> not help improve code quality of an already released version either. >>> >>> This can already be achieve by passing EXTRA_CFLAGS='-Wno-error' into the >>> build command. I don't like changing the default option here. Better to >>> instead document how to disable the warning flags if necessary. >> >> Well, optimally it would only default to off in released versions, which is >> where the Werror behavior is just annoying without being useful. > > This I can agree with. Ok, would something to this tune be more acceptable? (non-gcc toolchains are missing and whitespace probably broken due to copy-paste, this is not a suggested patch but just an RFC for the approach) - Panu - diff --git a/mk/rte.vars.mk b/mk/rte.vars.mk index d5b36be..2ad969b 100644 --- a/mk/rte.vars.mk +++ b/mk/rte.vars.mk @@ -71,6 +71,10 @@ ifneq ($(BUILDING_RTE_SDK),) ifeq ($(RTE_BUILD_COMBINE_LIBS),) RTE_BUILD_COMBINE_LIBS := n endif + # see if we're building from git + ifneq ($(wildcard $(RTE_SDK)/.git),) + DEVEL_BUILD := y + endif endif RTE_LIBNAME := $(CONFIG_RTE_LIBNAME:"%"=%) diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk index 88f235c..a14ae44 100644 --- a/mk/toolchain/gcc/rte.vars.mk +++ b/mk/toolchain/gcc/rte.vars.mk @@ -71,12 +71,16 @@ ifeq (,$(findstring -O0,$(EXTRA_CFLAGS))) endif endif -WERROR_FLAGS := -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes +WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith WERROR_FLAGS += -Wcast-align -Wnested-externs -Wcast-qual WERROR_FLAGS += -Wformat-nonliteral -Wformat-security WERROR_FLAGS += -Wundef -Wwrite-strings +ifeq ($(DEVEL_BUILD),y) +WERROR_FLAGS += -Werror +endif + # process cpu flags include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk