From patchwork Thu Feb 12 11:49:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Doherty, Declan" X-Patchwork-Id: 3193 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id AE36E9A99; Thu, 12 Feb 2015 12:46:49 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 50C309A91 for ; Thu, 12 Feb 2015 12:46:48 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 12 Feb 2015 03:46:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,565,1418112000"; d="scan'208";a="453644615" Received: from dwdohert-dpdk-fedora-20.ir.intel.com ([163.33.213.98]) by FMSMGA003.fm.intel.com with ESMTP; 12 Feb 2015 03:32:04 -0800 Message-ID: <54DC9353.2060209@intel.com> Date: Thu, 12 Feb 2015 11:49:39 +0000 From: Declan Doherty User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Tomasz Kulasek , dev@dpdk.org References: <1421671390-8560-1-git-send-email-tomaszx.kulasek@intel.com> <1422521516-780-1-git-send-email-tomaszx.kulasek@intel.com> <1422521516-780-3-git-send-email-tomaszx.kulasek@intel.com> In-Reply-To: <1422521516-780-3-git-send-email-tomaszx.kulasek@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 2/3] test: Unit tests for mode 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29/01/15 08:51, Tomasz Kulasek wrote: > This patch adds unit tests for mode 4. It is split into separate > file to avoid problems with other modes that does not need to > look into packets payload. > This patch includes also a modification of maximum number of ports > used in their tests for bonding modes 0-3 from 16 to 6. > > v3 changes > - Patch re-created for current release to maintain consistency > > > Signed-off-by: Pawel Wodkowski > Signed-off-by: Tomasz Kulasek > --- > app/test/Makefile | 1 + > app/test/test_link_bonding.c | 2 +- > app/test/test_link_bonding_mode4.c | 1412 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 1414 insertions(+), 1 deletion(-) > create mode 100644 app/test/test_link_bonding_mode4.c > >.... > Hey Tomasz, due to commit # ecd9d5193b85f22ff3d5fa76fb26d1363b293d94 which modified the initialize_eth_header API you need to make the following modification for a clean compilation. initialize_ipv4_header(&pkt_ip_hdr.v4, ip_src[3], ip_dst[3], pktlen); diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index f8d0955..c35129f 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -684,7 +684,8 @@ generate_packets(struct ether_addr *src_mac, int retval; - initialize_eth_header(&pkt_eth_hdr, src_mac, dst_mac, vlan_enable, vlan_id); + initialize_eth_header(&pkt_eth_hdr, src_mac, dst_mac, ip4_type, + vlan_enable, vlan_id); if (ip4_type)