diff mbox series

[v2,03/11] app/testpmd: support IPv4 fragments

Message ID	53a309585984c6b1605598d6ccb36ef8a65a0c76.1601586563.git.dekelp@nvidia.com (mailing list archive)
State	Superseded, archived
Delegated to:	Ferruh Yigit
Headers	From: Dekel Peled <dekelp@nvidia.com> To: orika@nvidia.com, thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com, konstantin.ananyev@intel.com, olivier.matz@6wind.com, wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, matan@nvidia.com, shahafs@nvidia.com, viacheslavo@nvidia.com Cc: dev@dpdk.org Date: Fri, 2 Oct 2020 00:15:00 +0300 Message-Id: <53a309585984c6b1605598d6ccb36ef8a65a0c76.1601586563.git.dekelp@nvidia.com> In-Reply-To: <cover.1601586563.git.dekelp@nvidia.com> References: <cover.1601474841.git.dekelp@nvidia.com> <cover.1601586563.git.dekelp@nvidia.com> Subject: [dpdk-dev] [PATCH v2 03/11] app/testpmd: support IPv4 fragments Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	support match on L3 fragmented packets \| [v2,00/11] support match on L3 fragmented packets [v2,01/11] ethdev: add extensions attributes to IPv6 item [v2,02/11] ethdev: add IPv6 fragment extension header item [v2,03/11] app/testpmd: support IPv4 fragments [v2,04/11] app/testpmd: support IPv6 fragments [v2,05/11] app/testpmd: support IPv6 fragment extension item [v2,06/11] net/mlx5: remove handling of ICMP fragmented packets [v2,07/11] net/mlx5: support match on IPv4 fragment packets [v2,08/11] net/mlx5: support match on IPv6 fragment packets [v2,09/11] net/mlx5: support match on IPv6 fragment ext. item [v2,10/11] doc: update release notes for MLX5 L3 frag support [v2,11/11] net/mlx5: enforce limitation on IPv6 next proto

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Dekel Peled Oct. 1, 2020, 9:15 p.m. UTC

This patch updates testpmd CLI to support fragment_offset field of
IPv4 header item.

To match on non-fragmented IPv4 packets, need to use pattern:
... ipv4 fragment_offset spec 0 fragment_offset mask 0x3fff ...
To match on fragmented IPv4 packets, need to use pattern:
... ipv4 fragment_offset spec 1 fragment_offset last 0x3fff
fragment_offset mask 0x3fff ...
(Use the full available range 1 to 0x3fff to include all possible
values.)
To match on any IPv4 packets, fragmented and non-fragmented,
the fragment_offset field should not be specified for match.

Signed-off-by: Dekel Peled <dekelp@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Ori Kam Oct. 4, 2020, 1:47 p.m. UTC | #1

> -----Original Message-----
> From: Dekel Peled <dekelp@nvidia.com>
> Sent: Friday, October 2, 2020 12:15 AM
> Subject: [PATCH v2 03/11] app/testpmd: support IPv4 fragments
> 
> This patch updates testpmd CLI to support fragment_offset field of
> IPv4 header item.
> 
> To match on non-fragmented IPv4 packets, need to use pattern:
> ... ipv4 fragment_offset spec 0 fragment_offset mask 0x3fff ...
> To match on fragmented IPv4 packets, need to use pattern:
> ... ipv4 fragment_offset spec 1 fragment_offset last 0x3fff
> fragment_offset mask 0x3fff ...
> (Use the full available range 1 to 0x3fff to include all possible
> values.)
> To match on any IPv4 packets, fragmented and non-fragmented,
> the fragment_offset field should not be specified for match.
> 
> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
> ---



Acked-by: Ori Kam <orika@nvidia.com>
Thanks,
Ori

diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 6e04d53..a9bf29f 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -129,6 +129,7 @@  enum index {
 	ITEM_VLAN_INNER_TYPE,
 	ITEM_IPV4,
 	ITEM_IPV4_TOS,
+	ITEM_IPV4_FRAGMENT_OFFSET,
 	ITEM_IPV4_TTL,
 	ITEM_IPV4_PROTO,
 	ITEM_IPV4_SRC,
@@ -873,6 +874,7 @@  struct parse_action_priv {
 
 static const enum index item_ipv4[] = {
 	ITEM_IPV4_TOS,
+	ITEM_IPV4_FRAGMENT_OFFSET,
 	ITEM_IPV4_TTL,
 	ITEM_IPV4_PROTO,
 	ITEM_IPV4_SRC,
@@ -2097,6 +2099,13 @@  static int comp_set_raw_index(struct context *, const struct token *,
 		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ipv4,
 					     hdr.type_of_service)),
 	},
+	[ITEM_IPV4_FRAGMENT_OFFSET] = {
+		.name = "fragment_offset",
+		.help = "fragmentation flags and fragment offset",
+		.next = NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ipv4,
+					     hdr.fragment_offset)),
+	},
 	[ITEM_IPV4_TTL] = {
 		.name = "ttl",
 		.help = "time to live",