From patchwork Wed Jan 31 16:13:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 34783 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E34D1B7CB; Wed, 31 Jan 2018 17:13:49 +0100 (CET) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 81A321B7BD for ; Wed, 31 Jan 2018 17:13:48 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id 141so82413wme.3 for ; Wed, 31 Jan 2018 08:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=5N/fLSlV154ljXm6eRuLD/InrbvP4SDOkOv0v59mtN8=; b=TTTSKGt1iXniOk4+5s0gs2cGBpdD1Fe9w6njQq2Vmv/ThS+XSZNVvesURvcRZohXzp fd9yNCLRv2IfxqDLNVpA5frCQNeFFa47/fTnoyGjlRA5+6S0MWtyXeDKyGsCbRsXchwn RQnZTihmpMRXZL6KUz3v8emivrmjhEoXzDhQdgBVFA4t+hEqCXFOKuEFbNioICIC1M9A 3i2d4JgGxPJVe8qoLfHvEhtU+0UJLLhPsGvStuERZfRWNiR9OQ0bpKkwLxFSJoXnCgYU 4cPvzBTcHf67WZ99Cj+RN12+GnTYOYjKPd132BWRa/DJe7MXzSvSTHs/ckb7QFFWFngx g7Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5N/fLSlV154ljXm6eRuLD/InrbvP4SDOkOv0v59mtN8=; b=Y+74AxhftP+DQ7Y0Pn4v+1USxUadxR6kasUx9vKjOwdgSMM71HaD3siVRTsfqljojO reiVrkPBdbXLDy592ZbqpxgoFvDtLdobWM5AhI3oDl+j5Q+IL9O5fEmYHIaIn3mEbayN uLeCUg48+rIhZ8/AyATlBtkGJGWO1ZhW5iTVbVmMA48to2mcqZMI2Yki5y8+GXegylyY tCAHaMjQoUaN2WGcH4SbD/4yR36kP3ZGfQ9SdMLNYYr/NVmP8dIah8psZ2YPXDn4h0Xl HXriSSA/kuL+vK6FWZh3oNGRdornRDVPzApfNJT5CSEhYLNWC0jul3X80galOwmkrfq5 UrQA== X-Gm-Message-State: AKwxytflTWsxGnDiBwRq/F8Jb4Et4eGIzeXXFb6VUmK6zA9esX8DbTyi 8iZ39acEYM61wvlpgv2CL2JtNQKBBQ== X-Google-Smtp-Source: AH8x224LvgiPBm6DfN1V2/+nCsU37YWglgVux60TK12vfu099fV8yCSGffD4czsf577Ed4T/G5Ynmg== X-Received: by 10.28.214.67 with SMTP id n64mr21775179wmg.25.1517415227992; Wed, 31 Jan 2018 08:13:47 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 63sm61798wms.46.2018.01.31.08.13.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jan 2018 08:13:47 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil , Shahaf Shuler , Yongseok Koh , stable@dpdk.org Date: Wed, 31 Jan 2018 17:13:54 +0100 Message-Id: <4a50d97a4db1af0071ca41d67e0d0ac47e698d17.1517415209.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow priority on queue action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A single queue should have the same verbs priority as an RSS one. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 2360b0ee5..1ca2037ad 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -871,7 +871,7 @@ priv_flow_convert_items_validate(struct priv *priv, } parser->inner = IBV_FLOW_SPEC_INNER; } - if (parser->drop || parser->queues_n == 1) { + if (parser->drop) { parser->queue[HASH_RXQ_ETH].offset += cur_item->dst_sz; } else { for (n = 0; n != hash_rxq_init_n; ++n) @@ -1107,7 +1107,7 @@ priv_flow_convert(struct priv *priv, * Second step. * Allocate the memory space to store verbs specifications. */ - if (parser->drop || parser->queues_n == 1) { + if (parser->drop) { unsigned int priority = attr->priority + hash_rxq_init[HASH_RXQ_ETH].flow_priority; @@ -1172,14 +1172,9 @@ priv_flow_convert(struct priv *priv, * Last step. Complete missing specification to reach the RSS * configuration. */ - if (parser->queues_n > 1) { + if (!parser->drop) { priv_flow_convert_finalise(priv, parser); } else { - /* - * Action queue have their priority overridden with - * Ethernet priority, this priority needs to be adjusted to - * their most specific layer priority. - */ parser->queue[HASH_RXQ_ETH].ibv_attr->priority = attr->priority + hash_rxq_init[parser->layer].flow_priority;