From patchwork Sun Apr 15 17:39:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 38151 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38B651200A; Sun, 15 Apr 2018 19:39:23 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 355F212001 for ; Sun, 15 Apr 2018 19:39:22 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C0C3521AE0; Sun, 15 Apr 2018 13:39:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 15 Apr 2018 13:39:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=8Q/qwWapwwA2Vacka1yzFSRIMc cFBwnipnsyCx/QLbs=; b=SYL4yJYIHMtigYGCtKfAjlEpM3hBkbBXIJk0E/bLoM 7PExBGvr1jRmkQapL/lWjBkXMdkU7+xCzN/+esRL0f7rV1O/y4y5C5nZ7dJto1x/ yr0KbhmQ767p4+rfE6Z2Fz3PwIxroAudzsQRu/c1JUGyEOzArFIABEYdWnXuLVii 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=8Q/qwW apwwA2Vacka1yzFSRIMccFBwnipnsyCx/QLbs=; b=ZE6DfADHr2Q4JT3ursPL8S QQwO1YtdVl8KSNRv//p62N3H7V1MZvSuLcJCNE7lDLGs2Kv/fb+ra0b+8CN8riKo 7w6n7WfxOnQv8VSRlISRZamHx8VRpoFk7bos8wyHOPpLUaAICYw7esenr+7iqpqb dke/eVxrSsJwxwmNzHPj+XXpqRvgwuMr8n6w20648QnGYRjTTYdxmQT6dPoKhUWX iqjxzYDXyZIMTgXvwBA8pEdsAg+EafE1DhfX3HByZ69RgUQLfyUmGynF6CY6pQ/T Ig+EeJz51cbb2OdifUlC26dg9ug+MxpmoPchVIYtq4EEjq7SMPx9qp6YsJAdo58g == X-ME-Sender: Received: from xps.localnet (59.15.136.77.rev.sfr.net [77.136.15.59]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B77310256; Sun, 15 Apr 2018 13:39:15 -0400 (EDT) From: Thomas Monjalon To: Maxime Coquelin , Zhihong Wang Cc: dev@dpdk.org, jianfeng.tan@intel.com, tiwei.bie@intel.com, yliu@fridaylinux.org, cunming.liang@intel.com, xiao.w.wang@intel.com, dan.daly@intel.com, ferruh.yigit@intel.com, bruce.richardson@intel.com Date: Sun, 15 Apr 2018 19:39:10 +0200 Message-ID: <3690370.7WaqRWydSG@xps> In-Reply-To: References: <1517614137-62926-1-git-send-email-zhihong.wang@intel.com> <20180402114656.17090-3-zhihong.wang@intel.com> MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/5] vhost: support selective datapath X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/04/2018 10:02, Maxime Coquelin: > On 04/02/2018 01:46 PM, Zhihong Wang wrote: > > lib/librte_vhost/Makefile | 4 +- > > lib/librte_vhost/rte_vdpa.h | 87 +++++++++++++++++++++++++ > > lib/librte_vhost/rte_vhost_version.map | 7 ++ > > lib/librte_vhost/vdpa.c | 115 +++++++++++++++++++++++++++++++++ > > With the fix you suggested: > Reviewed-by: Maxime Coquelin This patch is not OK. It is updating the Makefile but not meson.build. I am fixing/amending it in master: --- a/lib/librte_vhost/meson.build +++ b/lib/librte_vhost/meson.build @@ -9,7 +9,8 @@ if has_libnuma == 1 endif version = 4 allow_experimental_apis = true -sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c', +sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vdpa.c', + 'vhost.c', 'vhost_user.c', 'virtio_net.c', 'vhost_crypto.c') -headers = files('rte_vhost.h', 'rte_vhost_crypto.h') +headers = files('rte_vhost.h', 'rte_vdpa.h', 'rte_vhost_crypto.h')