From patchwork Mon Mar 19 15:20:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 36278 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E71761B010; Mon, 19 Mar 2018 16:22:05 +0100 (CET) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 261F91AFE8 for ; Mon, 19 Mar 2018 16:22:03 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id 139so16561003wmn.2 for ; Mon, 19 Mar 2018 08:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=ioaC2UWp+eH9Oz9Z1b6h10kUCFP0rnjtmrWhXv7c5nY=; b=pSHo5ThLtfMRD/mhJYNiM8dJVaWt4EXxu7Qm4pmyY/zq+du/mUiWP6hJ+TL8ZxvPQH WaTJorto12RohdLUIFhAHU8JDyumCyp9BmDNYF40hRfA5EpjOT2K5gIKlriUmjYm51+X AVM5vYXBc7LzBV+XS1rk1NMc4d8ZJ3pEMA9kE1zSVPp6Hb0679tQUUzON5Y3H5dGoE2L Jz1KWUNIIeru22nodzW8ILENYv+5bR5MMMseWZDNz6xkflLaUQFJ+gQtQCxnMeyre5ve 753Mg2ZLtDs8toZpgoP5mssVF58F+zyiU0qnMOLTgftdTLtAzkZdHMmev4piUJEhC3IT DCeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=ioaC2UWp+eH9Oz9Z1b6h10kUCFP0rnjtmrWhXv7c5nY=; b=FybEehOR2E65+erFZIbRZPa2oe28BfeYovH4wPlFtERebVovjKS+121z4vaCbSuZyG 4QxhkdjobEqFIkxcRSEKcXtzzdLaXeYLJ2d4ZYNyIqVTCQAS0LewQJ1LFNqJozoGISUr DyNHdzIdlFIwkdY/sklVO1NqdD5bHMiL6uu986lE3ECogChkhQw9aVSMuCi1ZcQp1RIi vRXXavpePF7D6U8yr9T/TxquQtc6zfspumhETHxOnTGETa3oJa9CwX2S1Qdix7ytxO40 OwG230y+Xe4ZJN8ehKzxy8/QPZYM84Z44XdaybogHTaDeSgHENlnttKKjm4Q10X//tGB 7Oog== X-Gm-Message-State: AElRT7FiPyMmq/hzXJyljkdCN7O6s01C9QnnTvX8LJKG46ctRQxuOKEj dKMnlzeXCUPzO305h69Fisde X-Google-Smtp-Source: AG47ELs4gvJPijX6wMadLXVmchqp17IgCwYGH5gO66BSvkle4SurpiYAH3IOmd9+nhzZEPRBP+UFDA== X-Received: by 10.28.134.135 with SMTP id i129mr5669071wmd.160.1521472922721; Mon, 19 Mar 2018 08:22:02 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 59sm392566wro.35.2018.03.19.08.22.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Mar 2018 08:22:02 -0700 (PDT) From: Nelio Laranjeiro To: Adrien Mazarguil , Yongseok Koh Cc: dev@dpdk.org Date: Mon, 19 Mar 2018 16:20:55 +0100 Message-Id: <22400a4dabb6a70130d087a8769476044d521212.1521472647.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 3/3] net/mlx5: add a parameter for Netlink support in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All Netlink request the PMD will do can also be done by a iproute2 command line interface, letting the operator configure the VF behavior without having to modify the application nor reaching PMD limits (e.g. MAC address number limit). Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guides/nics/mlx5.rst | 11 +++++++++++ drivers/net/mlx5/mlx5.c | 9 ++++++++- drivers/net/mlx5/mlx5.h | 1 + 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 46d26e4c8..4c7bf1c56 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -135,6 +135,8 @@ Limitations - Flows with a VXLAN Network Identifier equal (or ends to be equal) to 0 are not supported. - VXLAN TSO and checksum offloads are not supported on VM. +- VF: flow rules created on VF devices can only match traffic targeted at the + configured MAC addresses (see ``rte_eth_dev_mac_addr_add()``). Statistics ---------- @@ -335,6 +337,15 @@ Run-time configuration Enabled by default. +- ``vf_nl_en`` parameter [int] + + A nonzero value enables Netlink requests from the VF to add/remove MAC + addresses or/and enable/disable promiscuous/all multicast on the Netdevice. + Otherwise the relevant configuration must be run with Linux iproute2 tools. + This is a prerequisite to receive this kind of traffic. + + Enabled by default, valid only on VF devices ignored otherwise. + Prerequisites ------------- diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 5ec152ab1..89bada409 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -69,6 +69,9 @@ /* Device parameter to enable hardware Rx vector. */ #define MLX5_RX_VEC_EN "rx_vec_en" +/* Activate Netlink support in VF mode. */ +#define MLX5_VF_NL_EN "vf_nl_en" + #ifndef HAVE_IBV_MLX5_MOD_MPW #define MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED (1 << 2) #define MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW (1 << 3) @@ -412,6 +415,8 @@ mlx5_args_check(const char *key, const char *val, void *opaque) config->tx_vec_en = !!tmp; } else if (strcmp(MLX5_RX_VEC_EN, key) == 0) { config->rx_vec_en = !!tmp; + } else if (strcmp(MLX5_VF_NL_EN, key) == 0) { + config->vf_nl_en = !!tmp; } else { DRV_LOG(WARNING, "%s: unknown parameter", key); rte_errno = EINVAL; @@ -443,6 +448,7 @@ mlx5_args(struct mlx5_dev_config *config, struct rte_devargs *devargs) MLX5_TXQ_MAX_INLINE_LEN, MLX5_TX_VEC_EN, MLX5_RX_VEC_EN, + MLX5_VF_NL_EN, NULL, }; struct rte_kvargs *kvlist; @@ -748,6 +754,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, .txq_inline = MLX5_ARG_UNSET, .txqs_inline = MLX5_ARG_UNSET, .inline_max_packet_sz = MLX5_ARG_UNSET, + .vf_nl_en = 1, }; len = snprintf(name, sizeof(name), PCI_PRI_FMT, @@ -964,7 +971,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, /* Register MAC address. */ priv->nl_socket = -1; priv->nl_sn = 0; - if (vf) { + if (vf && config.vf_nl_en) { priv->nl_socket = mlx5_nl_init(RTMGRP_LINK); if (priv->nl_socket < 0) priv->nl_socket = -1; diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 6a7e9f310..7cabf43cc 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -88,6 +88,7 @@ struct mlx5_dev_config { unsigned int tx_vec_en:1; /* Tx vector is enabled. */ unsigned int rx_vec_en:1; /* Rx vector is enabled. */ unsigned int mpw_hdr_dseg:1; /* Enable DSEGs in the title WQEBB. */ + unsigned int vf_nl_en:1; /* Enable Netlink requests in VF mode. */ unsigned int tso_max_payload_sz; /* Maximum TCP payload for TSO. */ unsigned int ind_table_max_size; /* Maximum indirection table size. */ int txq_inline; /* Maximum packet size for inlining. */