From patchwork Tue Apr 19 14:13:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 12115 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 2DA4E37B2; Tue, 19 Apr 2016 16:14:03 +0200 (CEST) Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 5955C37B1 for ; Tue, 19 Apr 2016 16:14:01 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id l6so28556597wml.1 for ; Tue, 19 Apr 2016 07:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=NDwzlLOuOpTJS1uKejz8wW9ATKLj+707ghMveAmJhvk=; b=HYICV1++r2rneb+TO2+yWhVbNKQtrJWZFW6bzt8R30mYKUYAwrXmgS4w/Wi7KBpVgo z8EeOaPWvtqFhpNG0GALA+1OiFqTKy+GxEuQtz7LDjQZI4zKAGoI2i3KxWA+HBwhi7/g Xd9Fk4YitH4Q6hcK2YCHJ3UIzrUmGXYCxMpoxdIuPivAskH6gCLeIxCl/DfZ+4FT4kVi a3DdetQro+XWyqyEi6Bgmre6Zm+vVhkdfDMY6BCws6V/avetd3yJOU1RdA+0z8Pd91Lo KHD6+wRLVDLqU+P5pGaV9t7Fub+qm9D/ot/wfoIS3dm2blEjG32+5it6Sq+wqou4sfFa dXLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=NDwzlLOuOpTJS1uKejz8wW9ATKLj+707ghMveAmJhvk=; b=Eg4l/j/Wa7aEs5+idhFKHgTXGC6gH9fLUlqKRHbF+R6wwQLMjzczPyXQVPL0umCCvZ /6jhU57nbRb1za1oX5QTWx568If+GNFwQ89bPoVR7mGG0QwpztgJeEdQh6lcCtmFZqsN JzFnC0Zcj0rLy8YOyrdFGl3zi6GufynKO0CqPU/uoi7FOgS5qDmTkqwQOhHnpOGZPCyb yveMGl5v6hR8/JkZitT9FxcnNDWWu6Td4/AgtZEQmdLBbJvfcgLAuBKW04qZK6ws5eAf ub6MRMyrszYt9NKStq84FJFIZiLwaLQNPD80oIVDAWeolyvszBP93eQhlqA4HNaJqJVY moWQ== X-Gm-Message-State: AOPr4FWBpqA6bVjZPBRfoF40ctgC9Ld2Hnp1LF/w3ajr8UUDkZMe408RZ31QfImbnVr/HlhL X-Received: by 10.194.158.226 with SMTP id wx2mr3309328wjb.91.1461075241127; Tue, 19 Apr 2016 07:14:01 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id 188sm4583628wmk.6.2016.04.19.07.14.00 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2016 07:14:00 -0700 (PDT) From: Thomas Monjalon To: maryam.tahhan@intel.com, harry.van.haaren@intel.com Cc: dev@dpdk.org Date: Tue, 19 Apr 2016 16:13:58 +0200 Message-ID: <2181162.yfzPt0qCzR@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1461074613-32360-1-git-send-email-thomas.monjalon@6wind.com> References: <1461074613-32360-1-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: remove deprecated statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-19 16:03, Thomas Monjalon: > Some statistics were deprecated since release 2.1 (49f386542af4). > > The last deprecated counter to be used was imcasts. > > The new counters should be added to extended statistics. > > Signed-off-by: Thomas Monjalon [...] > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -200,27 +200,9 @@ struct rte_eth_stats { > /**< Total of RX packets dropped by the HW, > * because there are no available mbufs (i.e. RX queues are full). > */ > - uint64_t ibadcrc __rte_deprecated; > - /**< Deprecated; Total of RX packets with CRC error. */ > - uint64_t ibadlen __rte_deprecated; > - /**< Deprecated; Total of RX packets with bad length. */ > uint64_t ierrors; /**< Total number of erroneous received packets. */ > uint64_t oerrors; /**< Total number of failed transmitted packets. */ > - uint64_t imcasts; > - /**< Deprecated; Total number of multicast received packets. */ > uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */ > - uint64_t fdirmatch __rte_deprecated; > - /**< Deprecated; Total number of RX packets matching a filter. */ > - uint64_t fdirmiss __rte_deprecated; > - /**< Deprecated; Total number of RX packets not matching any filter. */ > - uint64_t tx_pause_xon __rte_deprecated; > - /**< Deprecated; Total nb. of XON pause frame sent. */ > - uint64_t rx_pause_xon __rte_deprecated; > - /**< Deprecated; Total nb. of XON pause frame received. */ > - uint64_t tx_pause_xoff __rte_deprecated; > - /**< Deprecated; Total nb. of XOFF pause frame sent. */ > - uint64_t rx_pause_xoff __rte_deprecated; > - /**< Deprecated; Total nb. of XOFF pause frame received. */ > uint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]; > /**< Total number of queue RX packets. */ > uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]; I suggest to remove also the loopback statistics which are implemented only for igbvf and available as extended stats: --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -213,14 +213,6 @@ struct rte_eth_stats { /**< Total number of successfully transmitted queue bytes. */ uint64_t q_errors[RTE_ETHDEV_QUEUE_STAT_CNTRS]; /**< Total number of queue packets received that are dropped. */ - uint64_t ilbpackets; - /**< Total number of good packets received from loopback,VF Only */ - uint64_t olbpackets; - /**< Total number of good packets transmitted to loopback,VF Only */ - uint64_t ilbbytes; - /**< Total number of good bytes received from loopback,VF Only */ - uint64_t olbbytes; - /**< Total number of good bytes transmitted to loopback,VF Only */ }; --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -1805,10 +1805,6 @@ eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats) rte_stats->ibytes = hw_stats->gorc; rte_stats->opackets = hw_stats->gptc; rte_stats->obytes = hw_stats->gotc; - rte_stats->ilbpackets = hw_stats->gprlbc; - rte_stats->ilbbytes = hw_stats->gorlbc; - rte_stats->olbpackets = hw_stats->gptlbc; - rte_stats->olbbytes = hw_stats->gotlbc; } I'll send a v2 if no objection.