[3/3] app/testpmd: support stop specify lcore

Message ID 20251104040916.25864-4-fengchengwen@huawei.com (mailing list archive)
State Superseded
Delegated to: Stephen Hemminger
Headers
Series testpmd support stop specify lcore |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Functional success Functional Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/github-robot-post success github post: success
ci/iol-compile-arm64-testing success Testing PASS
ci/aws-unit-testing success Unit Testing PASS

Commit Message

fengchengwen Nov. 4, 2025, 4:09 a.m. UTC
This commit supports stop specify lcore, the command:

  stop fwd_core (lcore_id)

The background of this command:
1. Only some TCs are expected to generate traffic when the DCB function
   is tested based on txonly forwarding.
2. Because each lcore will process all the traffic of one TC, therefore,
   we could stop the lcores which process unexpected TCs by this
   command.

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 app/test-pmd/cmdline.c                      | 63 +++++++++++++++++++++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  7 +++
 2 files changed, 70 insertions(+)
  

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 22afbdbad3..e03f6e6181 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -150,6 +150,9 @@  static void cmd_help_long_parsed(void *parsed_result,
 			"    Stop packet forwarding, and display accumulated"
 			" statistics.\n\n"
 
+			"stop fwd_core (lcore_id)\n"
+			"    Stop specify lcore's forwarding.\n\n"
+
 			"quit\n"
 			"    Quit to prompt.\n\n"
 		);
@@ -3975,6 +3978,65 @@  static cmdline_parse_inst_t cmd_stop = {
 	},
 };
 
+/* *** stop specify forward core *** */
+struct cmd_stop_fwd_core_result {
+	cmdline_fixed_string_t stop;
+	cmdline_fixed_string_t fwd_core;
+	uint32_t lcore_id;
+};
+
+static void
+cmd_stop_fwd_core_parsed(void *parsed_result,
+			 __rte_unused struct cmdline *cl,
+			 __rte_unused void *data)
+{
+	struct cmd_stop_fwd_core_result *res = parsed_result;
+	struct fwd_lcore *fc = lcore_to_fwd_lcore(res->lcore_id);
+
+	if (test_done) {
+		fprintf(stderr, "Packet forwarding not started\n");
+		return;
+	}
+
+	if (fc == NULL) {
+		fprintf(stderr, "core: %u not in the forward corelist.\n", res->lcore_id);
+		return;
+	}
+
+	if (fc->stopped) {
+		fprintf(stderr, "core: %u already stopped!\n", res->lcore_id);
+		return;
+	}
+
+	printf("Telling core: %u to stop...", res->lcore_id);
+	fc->stopped = 1;
+	printf("\nWaiting for core: %u to finish...\n", res->lcore_id);
+	rte_eal_wait_lcore(res->lcore_id);
+	printf("Done.\n");
+}
+
+static cmdline_parse_token_string_t cmd_stop_fwd_core_stop =
+	TOKEN_STRING_INITIALIZER(struct cmd_stop_fwd_core_result,
+			stop, "stop");
+static cmdline_parse_token_string_t cmd_stop_fwd_core_fwd_core =
+	TOKEN_STRING_INITIALIZER(struct cmd_stop_fwd_core_result,
+			fwd_core, "fwd_core");
+static cmdline_parse_token_num_t cmd_stop_fwd_core_lcore_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_stop_fwd_core_result,
+			lcore_id, RTE_UINT32);
+
+static cmdline_parse_inst_t cmd_stop_fwd_core = {
+	.f = cmd_stop_fwd_core_parsed,
+	.data = NULL,
+	.help_str = "stop fwd_core <lcore_id>: stop specify lcore's forwarding.",
+	.tokens = {
+		(void *)&cmd_stop_fwd_core_stop,
+		(void *)&cmd_stop_fwd_core_fwd_core,
+		(void *)&cmd_stop_fwd_core_lcore_id,
+		NULL,
+	},
+};
+
 static unsigned int
 get_ptype(char *value)
 {
@@ -14051,6 +14113,7 @@  static cmdline_parse_ctx_t builtin_ctx[] = {
 	&cmd_config_dcb,
 	&cmd_read_rxd_txd,
 	&cmd_stop,
+	&cmd_stop_fwd_core,
 	&cmd_mac_addr,
 	&cmd_set_fwd_eth_peer,
 	&cmd_set_xstats_hide_zero,
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index e423abd40e..0a362d06b8 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -143,6 +143,13 @@  Stop packet forwarding, and display accumulated statistics::
 
    testpmd> stop
 
+stop fwd_core
+~~~~~~~~~~~~~
+
+Stop specify lcore's forwarding::
+
+   testpmd> stop fwd_core (lcore_id)
+
 quit
 ~~~~