net/i40e: fix missing support for RSS IPv4

Message ID 20250705215412.200958-1-dhanya.r.pillai@intel.com (mailing list archive)
State Accepted
Delegated to: Bruce Richardson
Headers
Series net/i40e: fix missing support for RSS IPv4 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing warning Testing issues
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/aws-unit-testing success Unit Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Dhanya Pillai July 5, 2025, 9:54 p.m. UTC
Currently, i40e driver is missing support for RTE_ETH_RSS_IPV4
flag. Configuring rss function to RTE_ETH_RSS_IPV4 returns
invalid rss hash function value.

Fixes: a286ebeb0714 ("net/i40e: add dynamic mapping of SW flow types to HW pctypes")
Cc: stable@dpdk.org

Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
---
 drivers/net/intel/i40e/i40e_rxtx.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Bruce Richardson July 7, 2025, 4:32 p.m. UTC | #1
On Sat, Jul 05, 2025 at 09:54:07PM +0000, Dhanya Pillai wrote:
> Currently, i40e driver is missing support for RTE_ETH_RSS_IPV4
> flag. Configuring rss function to RTE_ETH_RSS_IPV4 returns
> invalid rss hash function value.
> 
> Fixes: a286ebeb0714 ("net/i40e: add dynamic mapping of SW flow types to HW pctypes")
> Cc: stable@dpdk.org
> 

Reported-by: Morten Brørup <mb@smartsharesystems.com>
> Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied to dpdk-next-net-intel,

Thanks,
/Bruce
  

Patch

diff --git a/drivers/net/intel/i40e/i40e_rxtx.c b/drivers/net/intel/i40e/i40e_rxtx.c
index 0b06130fe5..aba3c11ee5 100644
--- a/drivers/net/intel/i40e/i40e_rxtx.c
+++ b/drivers/net/intel/i40e/i40e_rxtx.c
@@ -3657,6 +3657,8 @@  i40e_set_default_pctype_table(struct rte_eth_dev *dev)
 	ad->flow_types_mask = 0ULL;
 	ad->pctypes_mask = 0ULL;
 
+	ad->pctypes_tbl[RTE_ETH_FLOW_IPV4] =
+				(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_OTHER);
 	ad->pctypes_tbl[RTE_ETH_FLOW_FRAG_IPV4] =
 				(1ULL << I40E_FILTER_PCTYPE_FRAG_IPV4);
 	ad->pctypes_tbl[RTE_ETH_FLOW_NONFRAG_IPV4_UDP] =