diff mbox series

net/ice: update log message

Message ID 20250502152601.699443-1-dhanya.r.pillai@intel.com (mailing list archive)
State Superseded
Delegated to: Bruce Richardson
Headers
Series net/ice: update log message |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/aws-unit-testing success Unit Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing fail Testing issues
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-mellanox-Functional fail Functional Testing issues
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Pillai, Dhanya R May 2, 2025, 3:25 p.m. UTC 
Added log message for ddp package load failure.

mailmap: update contributor entry

Signed-off-by: Pillai, Dhanya R <dhanya.r.pillai@intel.com>
---
 .mailmap                           | 1 +
 drivers/net/intel/ice/ice_ethdev.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Patrick Robb May 4, 2025, 9:18 p.m. UTC | #1 
Please disregard the Community Lab DTS failure just reported on this
patchseries. I need to reconfigure the testbed and rerun the test.

On Fri, May 2, 2025 at 11:26 AM Pillai, Dhanya R <dhanya.r.pillai@intel.com>
wrote:

> Added log message for ddp package load failure.
>
> mailmap: update contributor entry
>
> Signed-off-by: Pillai, Dhanya R <dhanya.r.pillai@intel.com>
> ---
>  .mailmap                           | 1 +
>  drivers/net/intel/ice/ice_ethdev.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.mailmap b/.mailmap
> index d8439b79ce..0f66ad834f 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -353,6 +353,7 @@ Devendra Singh Rawat <dsinghrawat@marvell.com>
>  Dex Chen <dex.chen@ruckuswireless.com>
>  Dexia Li <dexia.li@jaguarmicro.com>
>  Dexuan Cui <decui@microsoft.com>
> +Dhanya Pillai <dhanya.r.pillai@intel.com>
>  Dharmik Thakkar <dharmikjayesh.thakkar@arm.com> <dharmik.thakkar@arm.com>
>  Dheemanth Mallikarjun <dheemanthm@vmware.com>
>  Dhruv Tripathi <dhruv.tripathi@arm.com>
> diff --git a/drivers/net/intel/ice/ice_ethdev.c
> b/drivers/net/intel/ice/ice_ethdev.c
> index 21d3795954..bd55e0e7e1 100644
> --- a/drivers/net/intel/ice/ice_ethdev.c
> +++ b/drivers/net/intel/ice/ice_ethdev.c
> @@ -2026,7 +2026,7 @@ int ice_load_pkg(struct ice_adapter *adapter, bool
> use_dsn, uint64_t dsn)
>
>         err = ice_copy_and_init_pkg(hw, buf, bufsz,
> adapter->devargs.ddp_load_sched);
>         if (!ice_is_init_pkg_successful(err)) {
> -               PMD_INIT_LOG(ERR, "ice_copy_and_init_hw failed: %d", err);
> +               PMD_INIT_LOG(ERR, "Failed to load ddp package: %d", err);
>                 free(buf);
>                 return -1;
>         }
> --
> 2.43.0
>
>
Anatoly Burakov May 9, 2025, 2:46 p.m. UTC | #2 
On 5/2/2025 5:25 PM, Pillai, Dhanya R wrote:
> Added log message for ddp package load failure.
> 

Judging by the code, the log message already existed, so technically 
it's not "adding" anything. IMO a better wording would be:

"Clarified log message for DDP package load failure".

> mailmap: update contributor entry

I don't think it's necessary to call this out.

With above changes (can be done on apply),

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
diff mbox series

Patch

diff --git a/.mailmap b/.mailmap
index d8439b79ce..0f66ad834f 100644
--- a/.mailmap
+++ b/.mailmap
@@ -353,6 +353,7 @@  Devendra Singh Rawat <dsinghrawat@marvell.com>
 Dex Chen <dex.chen@ruckuswireless.com>
 Dexia Li <dexia.li@jaguarmicro.com>
 Dexuan Cui <decui@microsoft.com>
+Dhanya Pillai <dhanya.r.pillai@intel.com>
 Dharmik Thakkar <dharmikjayesh.thakkar@arm.com> <dharmik.thakkar@arm.com>
 Dheemanth Mallikarjun <dheemanthm@vmware.com>
 Dhruv Tripathi <dhruv.tripathi@arm.com>
diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
index 21d3795954..bd55e0e7e1 100644
--- a/drivers/net/intel/ice/ice_ethdev.c
+++ b/drivers/net/intel/ice/ice_ethdev.c
@@ -2026,7 +2026,7 @@  int ice_load_pkg(struct ice_adapter *adapter, bool use_dsn, uint64_t dsn)
 
 	err = ice_copy_and_init_pkg(hw, buf, bufsz, adapter->devargs.ddp_load_sched);
 	if (!ice_is_init_pkg_successful(err)) {
-		PMD_INIT_LOG(ERR, "ice_copy_and_init_hw failed: %d", err);
+		PMD_INIT_LOG(ERR, "Failed to load ddp package: %d", err);
 		free(buf);
 		return -1;
 	}