net/igc: fix xstats name

Message ID 20250409010711.761050-1-kaiwenx.deng@intel.com (mailing list archive)
State Superseded
Delegated to: Bruce Richardson
Headers
Series net/igc: fix xstats name |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Functional success Functional Testing PASS

Commit Message

Kaiwen Deng April 9, 2025, 1:07 a.m. UTC
The xstats name needs to be changed correctly
tx_size_1023_to_max_packets should be tx_size_1024_to_max_packets.

Fixes: e6defdfddc3b ("net/igc: enable statistics")
Cc: stable@dpdk.org

Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
 drivers/net/intel/e1000/igc_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Stephen Hemminger April 9, 2025, 3:55 a.m. UTC | #1
On Wed,  9 Apr 2025 09:07:11 +0800
Kaiwen Deng <kaiwenx.deng@intel.com> wrote:

> The xstats name needs to be changed correctly
> tx_size_1023_to_max_packets should be tx_size_1024_to_max_packets.
> 
> Fixes: e6defdfddc3b ("net/igc: enable statistics")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
>  drivers/net/intel/e1000/igc_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/intel/e1000/igc_ethdev.c b/drivers/net/intel/e1000/igc_ethdev.c
> index e712cfcf7c..68444e4fba 100644
> --- a/drivers/net/intel/e1000/igc_ethdev.c
> +++ b/drivers/net/intel/e1000/igc_ethdev.c
> @@ -181,7 +181,7 @@ static const struct rte_igc_xstats_name_off rte_igc_stats_strings[] = {
>  	{"tx_size_256_to_511_packets", offsetof(struct e1000_hw_stats, ptc511)},
>  	{"tx_size_512_to_1023_packets", offsetof(struct e1000_hw_stats,
>  		ptc1023)},
> -	{"tx_size_1023_to_max_packets", offsetof(struct e1000_hw_stats,
> +	{"tx_size_1024_to_max_packets", offsetof(struct e1000_hw_stats,
>  		ptc1522)},
>  	{"tx_multicast_packets", offsetof(struct e1000_hw_stats, mptc)},
>  	{"tx_broadcast_packets", offsetof(struct e1000_hw_stats, bptc)},


Please don't send same patch twice.
  
Kaiwen Deng April 10, 2025, 6:57 a.m. UTC | #2
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, April 9, 2025 11:56 AM
> To: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>;
> Alvin Zhang <alvinx.zhang@intel.com>
> Subject: Re: [PATCH] net/igc: fix xstats name
> 
> On Wed,  9 Apr 2025 09:07:11 +0800
> Kaiwen Deng <kaiwenx.deng@intel.com> wrote:
> 
> > The xstats name needs to be changed correctly
> > tx_size_1023_to_max_packets should be tx_size_1024_to_max_packets.
> >
> > Fixes: e6defdfddc3b ("net/igc: enable statistics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> > ---
> >  drivers/net/intel/e1000/igc_ethdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/intel/e1000/igc_ethdev.c
> > b/drivers/net/intel/e1000/igc_ethdev.c
> > index e712cfcf7c..68444e4fba 100644
> > --- a/drivers/net/intel/e1000/igc_ethdev.c
> > +++ b/drivers/net/intel/e1000/igc_ethdev.c
> > @@ -181,7 +181,7 @@ static const struct rte_igc_xstats_name_off
> rte_igc_stats_strings[] = {
> >  	{"tx_size_256_to_511_packets", offsetof(struct e1000_hw_stats,
> ptc511)},
> >  	{"tx_size_512_to_1023_packets", offsetof(struct e1000_hw_stats,
> >  		ptc1023)},
> > -	{"tx_size_1023_to_max_packets", offsetof(struct e1000_hw_stats,
> > +	{"tx_size_1024_to_max_packets", offsetof(struct e1000_hw_stats,
> >  		ptc1522)},
> >  	{"tx_multicast_packets", offsetof(struct e1000_hw_stats, mptc)},
> >  	{"tx_broadcast_packets", offsetof(struct e1000_hw_stats, bptc)},
> 
> 
> Please don't send same patch twice.
Hi Stephen,
Thanks for your review.
The two patches I posted earlier were fixes for the same issue for both igb and igc drivers. 
Now I merged those two patches into one patch to fix the issue.
  

Patch

diff --git a/drivers/net/intel/e1000/igc_ethdev.c b/drivers/net/intel/e1000/igc_ethdev.c
index e712cfcf7c..68444e4fba 100644
--- a/drivers/net/intel/e1000/igc_ethdev.c
+++ b/drivers/net/intel/e1000/igc_ethdev.c
@@ -181,7 +181,7 @@  static const struct rte_igc_xstats_name_off rte_igc_stats_strings[] = {
 	{"tx_size_256_to_511_packets", offsetof(struct e1000_hw_stats, ptc511)},
 	{"tx_size_512_to_1023_packets", offsetof(struct e1000_hw_stats,
 		ptc1023)},
-	{"tx_size_1023_to_max_packets", offsetof(struct e1000_hw_stats,
+	{"tx_size_1024_to_max_packets", offsetof(struct e1000_hw_stats,
 		ptc1522)},
 	{"tx_multicast_packets", offsetof(struct e1000_hw_stats, mptc)},
 	{"tx_broadcast_packets", offsetof(struct e1000_hw_stats, bptc)},