diff mbox series

[1/1] examples/ipsec-secgw: resolve segfault for IPv6 packets

Message ID 20250327070300.2839933-1-rkudurumalla@marvell.com (mailing list archive)
State New
Delegated to: akhil goyal
Headers
Series [1/1] examples/ipsec-secgw: resolve segfault for IPv6 packets |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-mellanox-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Rakesh Kudurumalla March 27, 2025, 7:03 a.m. UTC 
While running ipsec-secgw application if IPV6 rules are not
configured in ipsec configuration lpm look up fails and
destination port is updated as BAD_PORT.During process_packet
ethernet_hdr is updated resulting in crash due out of bound.
This patch fixes the same.
Fixes: 6eb3ba03995c ("examples/ipsec-secgw: support poll mode NEON LPM lookup")

Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
 examples/ipsec-secgw/ipsec_neon.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/examples/ipsec-secgw/ipsec_neon.h b/examples/ipsec-secgw/ipsec_neon.h
index 8b93b4b52e..fc04000336 100644
--- a/examples/ipsec-secgw/ipsec_neon.h
+++ b/examples/ipsec-secgw/ipsec_neon.h
@@ -23,6 +23,7 @@  processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t dst_port[FWDSTEP],
 	uint32x4_t ve[FWDSTEP];
 	uint32_t *p[FWDSTEP];
 	struct rte_mbuf *pkt;
+	uint16_t port;
 	uint32_t val;
 	uint8_t i;
 
@@ -34,7 +35,8 @@  processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t dst_port[FWDSTEP],
 			*l_pkt |= 1;
 
 		p[i] = rte_pktmbuf_mtod(pkt, uint32_t *);
-		ve[i] = vreinterpretq_u32_s32(val_eth[dst_port[i]]);
+		port = (dst_port[i] == BAD_PORT) ? 0 : dst_port[i];
+		ve[i] = vreinterpretq_u32_s32(val_eth[port]);
 		te[i] = vld1q_u32(p[i]);
 
 		/* Update last 4 bytes */
@@ -76,6 +78,7 @@  process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, uint64_t tx_offloads,
 {
 	struct rte_ether_hdr *eth_hdr;
 	uint32x4_t te, ve;
+	uint16_t port;
 	uint32_t val;
 
 	/* Check if it is a large packet */
@@ -85,7 +88,8 @@  process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, uint64_t tx_offloads,
 	eth_hdr = rte_pktmbuf_mtod(pkt, struct rte_ether_hdr *);
 
 	te = vld1q_u32((uint32_t *)eth_hdr);
-	ve = vreinterpretq_u32_s32(val_eth[dst_port[0]]);
+	port = (dst_port[0] == BAD_PORT) ? 0 : dst_port[0];
+	ve = vreinterpretq_u32_s32(val_eth[port]);
 
 	val = vgetq_lane_u32(te, 3);
 #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN