diff mbox series

config/arm: update NVIDIA BlueField-3 configuration

Message ID 20250218104942.81984-1-getelson@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series config/arm: update NVIDIA BlueField-3 configuration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-compile-amd64-testing success Testing PASS

Commit Message

Gregory Etelson Feb. 18, 2025, 10:49 a.m. UTC 
ARM configuration requires explicit `mcpu` specifications in the
implementor description.

The patch adds `mcpu` and `flags` description for the NVIDIA
BlueField-3 configuration.

Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
 config/arm/meson.build | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Wathsala Wathawana Vithanage Feb. 19, 2025, 4:35 p.m. UTC | #1 
> Subject: [PATCH] config/arm: update NVIDIA BlueField-3 configuration
> 
> ARM configuration requires explicit `mcpu` specifications in the implementor
> description.
> 
> The patch adds `mcpu` and `flags` description for the NVIDIA
> BlueField-3 configuration.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
>  config/arm/meson.build | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 5302861e2c..74f4dd4e1f 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -85,6 +85,11 @@ part_number_config_arm = {
>      },
>      '0xd42': {
>          'march': 'armv8.4-a',
> +        'mcpu' : 'cortex-a78ae',
> +        'flags': [
> +            ['RTE_MAX_LCORE', 16],
> +            ['RTE_MAX_NUMA_NODES', 1]
> +        ],
>      },
>      '0xd49': {
>          'mcpu': 'neoverse-n2',
> --
> 2.45.2

Acked-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
Thomas Monjalon Feb. 19, 2025, 5:32 p.m. UTC | #2 
19/02/2025 17:35, Wathsala Wathawana Vithanage:
> > Subject: [PATCH] config/arm: update NVIDIA BlueField-3 configuration
> > 
> > ARM configuration requires explicit `mcpu` specifications in the implementor
> > description.
> > 
> > The patch adds `mcpu` and `flags` description for the NVIDIA
> > BlueField-3 configuration.
> > 
> > Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> 
> Acked-by: Wathsala Vithanage <wathsala.vithanage@arm.com>

Adding error message:
"
The build was broken for BlueField-3:
    ERROR: Problem encountered:
    No suitable Arm mcpu name or custom mcpu definition object found.
"

and
Fixes: c02c01dbf907 ("config/arm: prefer strict use of -mcpu if supported")

Applied, thanks.
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 5302861e2c..74f4dd4e1f 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -85,6 +85,11 @@  part_number_config_arm = {
     },
     '0xd42': {
         'march': 'armv8.4-a',
+        'mcpu' : 'cortex-a78ae',
+        'flags': [
+            ['RTE_MAX_LCORE', 16],
+            ['RTE_MAX_NUMA_NODES', 1]
+        ],
     },
     '0xd49': {
         'mcpu': 'neoverse-n2',