diff mbox series

[2/2] app/testpmd: use flags from user if it is set

Message ID 20250218103322.166461-3-gavinl@nvidia.com (mailing list archive)
State Accepted
Delegated to: Stephen Hemminger
Headers
Series use flags from user if it is set |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-intel-Functional pending Functional Testing pending
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-compile-amd64-testing success Testing PASS

Commit Message

Minggang Li(Gavin) Feb. 18, 2025, 10:33 a.m. UTC 
It's user's responsibility to set correct flags, especially the G bit, to
distinguish the protocols, VXLAN and VXLAN-GBP, sharing the same port 4789.

It will be set to 0x8 if user does not specify the flags.

Fixes: da118115d95c ("app/testpmd: support matching any VXLAN field")
Signed-off-by: Minggang Li(Gavin) <gavinl@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Dariusz Sosnowski Feb. 18, 2025, 10:56 a.m. UTC | #1 
> -----Original Message-----
> From: Minggang Li(Gavin) <gavinl@nvidia.com>
> Sent: Tuesday, February 18, 2025 11:33
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-Thomas
> Monjalon (EXTERNAL) <thomas@monjalon.net>; Aman Singh
> <aman.deep.singh@intel.com>; Minggang(Gavin) Li <gavinl@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH 2/2] app/testpmd: use flags from user if it is set
> 
> External email: Use caution opening links or attachments
> 
> 
> It's user's responsibility to set correct flags, especially the G bit, to distinguish the
> protocols, VXLAN and VXLAN-GBP, sharing the same port 4789.
> 
> It will be set to 0x8 if user does not specify the flags.
> 
> Fixes: da118115d95c ("app/testpmd: support matching any VXLAN field")
> Signed-off-by: Minggang Li(Gavin) <gavinl@nvidia.com>

Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Best regards,
Dariusz Sosnowski
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index e1720e54d7..3947304b63 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -13598,7 +13598,8 @@  update_fields(uint8_t *buf, struct rte_flow_item *item, uint16_t next_proto)
 		break;
 	case RTE_FLOW_ITEM_TYPE_VXLAN:
 		vxlan = (struct rte_vxlan_hdr *)buf;
-		vxlan->vx_flags = 0x08;
+		if (!vxlan->flags)
+			vxlan->flags = 0x08;
 		break;
 	case RTE_FLOW_ITEM_TYPE_VXLAN_GPE:
 		gpe = (struct rte_vxlan_gpe_hdr *)buf;