diff mbox series

[19/32] net/dpaa2: replace memcpy with assignment

Message ID	20250208203142.242284-20-stephen@networkplumber.org (mailing list archive)
State	New
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com> Subject: [PATCH 19/32] net/dpaa2: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:11 -0800 Message-ID: <20250208203142.242284-20-stephen@networkplumber.org> In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Use structure assignment instead of memcpy \| [00/32] Use structure assignment instead of memcpy [01/32] devtools/cocci: prefer structure assignment over memcpy [02/32] app/testpmd: replace memcpy with assignment [03/32] app/graph: replace memcpy with structure assignment [04/32] crypto/dpaa_sec: replace memcpy with assignment [05/32] dma/dpaa2: replace memcpy with assignment [06/32] eventdev: replace memcpy with assignment [07/32] event/dpaa2: replace memcpy with structure assignment [08/32] event/dsw: replace memcpy with assignment [09/32] ml/cnxk: replace memcpy with assignment [10/32] examples: replace memcpy with assignment [11/32] node: replace memcpy with assignment [12/32] pipeline: replace memcpy with assignment [13/32] sched: replace memcpy with structure assignment [14/32] table: replace memcpy with structure assignment [15/32] net/ntnic: replace memcpy with structure assignment [16/32] net/bnxt: replace memcpy with structure assignment [17/32] crypto/qat: replace memcpy with structure assignment [18/32] mempool/cnxk: replace memcpy with structure assignment [19/32] net/dpaa2: replace memcpy with assignment [20/32] net/enic: replace memcpy with assignment [21/32] net/intel/i40e: replace memcpy with structure assignment [22/32] net/nfp: replace memcpy with assignment [23/32] net/txgbe: replace memcpy with assignment [24/32] net/bnx2x: replace memcpy with structure assignment [25/32] net/dpaa2: replace memcpy with structure assignment [26/32] net/bonding: replace memcpy with structure assignment [27/32] net/cnxk: replace memcpy with structure assignment [28/32] net/enic: replace memcpy with structure assignment [29/32] net/iavf: replace memcpy with structure assignment [30/32] net/ice: replace memcpy with structure assignment [31/32] test: replace memcpy with structure assignment [32/32] test/cryptodev: replace memcpy with structure assignment

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Feb. 8, 2025, 8:22 p.m. UTC

Prefer structure assignment over memcpy.
Found by cocci/struct_assign.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/dpaa2/dpaa2_mux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hemant Agrawal Feb. 10, 2025, 10:39 a.m. UTC | #1

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

On 09-02-2025 01:52, Stephen Hemminger wrote:
> Prefer structure assignment over memcpy.
> Found by cocci/struct_assign.cocci
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   drivers/net/dpaa2/dpaa2_mux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c
> index 2f124313fa..3f259cd16f 100644
> --- a/drivers/net/dpaa2/dpaa2_mux.c
> +++ b/drivers/net/dpaa2/dpaa2_mux.c
> @@ -293,7 +293,7 @@ rte_pmd_dpaa2_mux_flow_create(uint32_t dpdmux_id,
>   				ret);
>   			goto creation_error;
>   		}
> -		rte_memcpy(&s_kg_cfg, &kg_cfg, sizeof(struct dpkg_profile_cfg));
> +		s_kg_cfg = kg_cfg;
>   	} else {
>   		if (memcmp(&s_kg_cfg, &kg_cfg,
>   			sizeof(struct dpkg_profile_cfg))) {

diff mbox series

Patch

diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c
index 2f124313fa..3f259cd16f 100644
--- a/drivers/net/dpaa2/dpaa2_mux.c
+++ b/drivers/net/dpaa2/dpaa2_mux.c
@@ -293,7 +293,7 @@  rte_pmd_dpaa2_mux_flow_create(uint32_t dpdmux_id,
 				ret);
 			goto creation_error;
 		}
-		rte_memcpy(&s_kg_cfg, &kg_cfg, sizeof(struct dpkg_profile_cfg));
+		s_kg_cfg = kg_cfg;
 	} else {
 		if (memcmp(&s_kg_cfg, &kg_cfg,
 			sizeof(struct dpkg_profile_cfg))) {