diff mbox series

[11/11] net/bnxt: address coverity control flow issues

Message ID	20250205172004.50395-12-ajit.khaparde@broadcom.com (mailing list archive)
State	Accepted
Delegated to:	Ajit Khaparde
Headers	From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: dev@dpdk.org Cc: thomas@monjalon.net, Peter Spreadborough <peter.spreadborough@broadcom.com> Subject: [PATCH 11/11] net/bnxt: address coverity control flow issues Date: Wed, 5 Feb 2025 09:20:04 -0800 Message-Id: <20250205172004.50395-12-ajit.khaparde@broadcom.com> In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	bnxt patch set \| [00/11] bnxt patch set [01/11] net/bnxt: disable TruFlow if compressed CQE is set [02/11] net/bnxt: simplify check for CQE mode [03/11] net/bnxt: fix Rx handler [04/11] net/bnxt: set burst handler correctly [05/11] net/bnxt/truFlow: Fix seg fault when rep are re-attached [06/11] net/bnxt: address coverity deadcode issue [07/11] net/bnxt: address coverity checked return issues [08/11] net/bnxt: address coverity overflow issues [09/11] net/bnxt: address coverity integer overflow issues [10/11] net/bnxt: address coverity uninitialized variables issues [11/11] net/bnxt: address coverity control flow issues

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/loongarch-compilation	success	Compilation OK
ci/loongarch-unit-testing	success	Unit Testing PASS
ci/github-robot: build	success	github build: passed
ci/iol-marvell-Functional	success	Functional Testing PASS
ci/iol-mellanox-Performance	success	Performance Testing PASS
ci/Intel-compilation	success	Compilation OK
ci/intel-Testing	success	Testing PASS
ci/iol-abi-testing	success	Testing PASS
ci/iol-unit-amd64-testing	success	Testing PASS
ci/intel-Functional	success	Functional PASS
ci/iol-compile-amd64-testing	success	Testing PASS
ci/iol-unit-arm64-testing	success	Testing PASS
ci/iol-sample-apps-testing	success	Testing PASS
ci/iol-compile-arm64-testing	success	Testing PASS
ci/iol-broadcom-Performance	success	Performance Testing PASS
ci/iol-intel-Performance	success	Performance Testing PASS
ci/iol-intel-Functional	success	Functional Testing PASS

Commit Message

Ajit Khaparde Feb. 5, 2025, 5:20 p.m. UTC

From: Peter Spreadborough <peter.spreadborough@broadcom.com>

This change addresses the CID 449072:  Control flow issues (DEADCODE)
reported by coverity.

Coverity issue: 449072
Signed-off-by: Peter Spreadborough <peter.spreadborough@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h b/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h
index 5e0d906fbd..e6f316539c 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h
@@ -1084,7 +1084,7 @@  bnxt_ulp_cap_feat_process(uint64_t feat_bits, uint64_t *out_bits)
 
 	if (bit & BNXT_ULP_FEATURE_BIT_PARENT_DMAC)
 		BNXT_DRV_DBG(ERR, "Parent Mac Address Feature is enabled\n");
-	if (bit & BNXT_ULP_FEATURE_BIT_PORT_DMAC)
+	else if (bit & BNXT_ULP_FEATURE_BIT_PORT_DMAC)
 		BNXT_DRV_DBG(ERR, "Port Mac Address Feature is enabled\n");
 	if (bit & BNXT_ULP_FEATURE_BIT_MULTI_TUNNEL_FLOW)
 		BNXT_DRV_DBG(ERR, "Multi Tunnel Flow Feature is enabled\n");