diff mbox series

[v4,24/42] net/dpaa: use rte strerror

Message ID	20241023082852.2780488-25-huangdengdui@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Thomas Monjalon
Headers	From: Dengdui Huang <huangdengdui@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>, <mb@smartsharesystems.com>, <david.marchand@redhat.com>, <iboukris@gmail.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <haijie1@huawei.com>, <liuyonglong@huawei.com> Subject: [PATCH v4 24/42] net/dpaa: use rte strerror Date: Wed, 23 Oct 2024 16:28:34 +0800 Message-ID: <20241023082852.2780488-25-huangdengdui@huawei.com> In-Reply-To: <20241023082852.2780488-1-huangdengdui@huawei.com> References: <20231114082539.1858594-44-huangdengdui@huawei.com> <20241023082852.2780488-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace strerror \| [v4,00/42] replace strerror [v4,01/42] devtools: forbid use of strerror [v4,02/42] eal: use rte strerror [v4,03/42] eventdev: use rte strerror [v4,04/42] latency: use rte strerror [v4,05/42] node: use rte strerror [v4,06/42] pdump: use rte strerror [v4,07/42] power: use rte strerror [v4,08/42] vhost: use rte strerror [v4,09/42] bpf: use rte strerror [v4,10/42] bus/cdx: use rte strerror [v4,11/42] bus/dpaa: use rte strerror [v4,12/42] bus/fslmc: use rte strerror [v4,13/42] bus/pci: use rte strerror [v4,14/42] bus/vdev: use rte strerror [v4,15/42] bus/vmbus: use rte strerror [v4,16/42] common/cnxk: use rte strerror [v4,17/42] common/mlx5: use rte strerror [v4,18/42] crypto/caam_jr: use rte strerror [v4,19/42] dma/idxd: use rte strerror [v4,20/42] net/af_packet: use rte strerror [v4,21/42] net/bnxt: use rte strerror [v4,22/42] net/af_xdp: use rte strerror [v4,23/42] net/bonding: use rte strerror [v4,24/42] net/dpaa: use rte strerror [v4,25/42] net/dpaa2: use rte strerror [v4,26/42] net/enetfec: use rte strerror [v4,27/42] net/failsafe: use rte strerror [v4,28/42] net/i40e: use rte strerror [v4,29/42] net/ice: use rte strerror [v4,30/42] net/ixgbe: use rte strerror [v4,31/42] net/memif: use rte strerror [v4,32/42] net/mlx4: use rte strerror [v4,33/42] net/mlx5: use rte strerror [v4,34/42] net/qede: use rte strerror [v4,35/42] net/sfc: use rte strerror [v4,36/42] net/tap: use rte strerror [v4,37/42] net/vhost: use rte strerror [v4,38/42] net/virtio: use rte strerror [v4,39/42] raw/ifpga: use rte strerror [v4,40/42] vdpa/ifc: use rte strerror [v4,41/42] vdpa/mlx5: use rte strerror [v4,42/42] vdpa/sfc: use rte strerror

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

huangdengdui Oct. 23, 2024, 8:28 a.m. UTC

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 drivers/net/dpaa/dpaa_ethdev.c  | 4 ++--
 drivers/net/dpaa/fmlib/fm_lib.c | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index e8d34e5898..ddf61395d6 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -1218,7 +1218,7 @@  int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
 		ret = qman_init_fq(rxq, flags, &opts);
 		if (ret) {
 			DPAA_PMD_ERR("Channel/Q association failed. fqid 0x%x "
-				"ret:%d(%s)", rxq->fqid, ret, strerror(ret));
+				"ret:%d(%s)", rxq->fqid, ret, rte_strerror(ret));
 			return ret;
 		}
 		if (dpaa_svr_family == SVR_LS1043A_FAMILY) {
@@ -1353,7 +1353,7 @@  dpaa_eth_eventq_attach(const struct rte_eth_dev *dev,
 	ret = qman_init_fq(rxq, flags, &opts);
 	if (ret) {
 		DPAA_PMD_ERR("Ev-Channel/Q association failed. fqid 0x%x "
-				"ret:%d(%s)", rxq->fqid, ret, strerror(ret));
+				"ret:%d(%s)", rxq->fqid, ret, rte_strerror(ret));
 		return ret;
 	}
 
diff --git a/drivers/net/dpaa/fmlib/fm_lib.c b/drivers/net/dpaa/fmlib/fm_lib.c
index b35feba004..fe19a5d8cb 100644
--- a/drivers/net/dpaa/fmlib/fm_lib.c
+++ b/drivers/net/dpaa/fmlib/fm_lib.c
@@ -103,7 +103,7 @@  fm_get_api_version(t_handle h_fm, ioc_fm_api_version_t *p_version)
 	ret = ioctl(p_dev->fd, FM_IOC_GET_API_VERSION, p_version);
 	if (ret) {
 		DPAA_PMD_ERR("cannot get API version, error %i (%s)",
-			     errno, strerror(errno));
+			     errno, rte_strerror(errno));
 		RETURN_ERROR(MINOR, E_INVALID_OPERATION, NO_MSG);
 	}
 	_fml_dbg("Finishing.");
@@ -276,7 +276,7 @@  fm_pcd_kg_scheme_set(t_handle h_fm_pcd,
 	ret = ioctl(p_pcd_dev->fd, FM_PCD_IOC_KG_SCHEME_SET, params);
 	if (ret) {
 		DPAA_PMD_ERR("  cannot set kg scheme, error %i (%s)",
-			     errno, strerror(errno));
+			     errno, rte_strerror(errno));
 		return NULL;
 	}
 
@@ -310,7 +310,7 @@  fm_pcd_kg_scheme_delete(t_handle h_scheme)
 
 	if (ioctl(p_pcd_dev->fd, FM_PCD_IOC_KG_SCHEME_DELETE, &id)) {
 		DPAA_PMD_WARN("cannot delete kg scheme, error %i (%s)",
-			      errno, strerror(errno));
+			      errno, rte_strerror(errno));
 		RETURN_ERROR(MINOR, E_INVALID_OPERATION, NO_MSG);
 	}