diff mbox series

[v4,22/42] net/af_xdp: use rte strerror

Message ID	20241023082852.2780488-23-huangdengdui@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Thomas Monjalon
Headers	From: Dengdui Huang <huangdengdui@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>, <mb@smartsharesystems.com>, <david.marchand@redhat.com>, <iboukris@gmail.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <haijie1@huawei.com>, <liuyonglong@huawei.com> Subject: [PATCH v4 22/42] net/af_xdp: use rte strerror Date: Wed, 23 Oct 2024 16:28:32 +0800 Message-ID: <20241023082852.2780488-23-huangdengdui@huawei.com> In-Reply-To: <20241023082852.2780488-1-huangdengdui@huawei.com> References: <20231114082539.1858594-44-huangdengdui@huawei.com> <20241023082852.2780488-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace strerror \| [v4,00/42] replace strerror [v4,01/42] devtools: forbid use of strerror [v4,02/42] eal: use rte strerror [v4,03/42] eventdev: use rte strerror [v4,04/42] latency: use rte strerror [v4,05/42] node: use rte strerror [v4,06/42] pdump: use rte strerror [v4,07/42] power: use rte strerror [v4,08/42] vhost: use rte strerror [v4,09/42] bpf: use rte strerror [v4,10/42] bus/cdx: use rte strerror [v4,11/42] bus/dpaa: use rte strerror [v4,12/42] bus/fslmc: use rte strerror [v4,13/42] bus/pci: use rte strerror [v4,14/42] bus/vdev: use rte strerror [v4,15/42] bus/vmbus: use rte strerror [v4,16/42] common/cnxk: use rte strerror [v4,17/42] common/mlx5: use rte strerror [v4,18/42] crypto/caam_jr: use rte strerror [v4,19/42] dma/idxd: use rte strerror [v4,20/42] net/af_packet: use rte strerror [v4,21/42] net/bnxt: use rte strerror [v4,22/42] net/af_xdp: use rte strerror [v4,23/42] net/bonding: use rte strerror [v4,24/42] net/dpaa: use rte strerror [v4,25/42] net/dpaa2: use rte strerror [v4,26/42] net/enetfec: use rte strerror [v4,27/42] net/failsafe: use rte strerror [v4,28/42] net/i40e: use rte strerror [v4,29/42] net/ice: use rte strerror [v4,30/42] net/ixgbe: use rte strerror [v4,31/42] net/memif: use rte strerror [v4,32/42] net/mlx4: use rte strerror [v4,33/42] net/mlx5: use rte strerror [v4,34/42] net/qede: use rte strerror [v4,35/42] net/sfc: use rte strerror [v4,36/42] net/tap: use rte strerror [v4,37/42] net/vhost: use rte strerror [v4,38/42] net/virtio: use rte strerror [v4,39/42] raw/ifpga: use rte strerror [v4,40/42] vdpa/ifc: use rte strerror [v4,41/42] vdpa/mlx5: use rte strerror [v4,42/42] vdpa/sfc: use rte strerror

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

huangdengdui Oct. 23, 2024, 8:28 a.m. UTC

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Maryam Tahhan Oct. 24, 2024, 5:05 p.m. UTC | #1

> The function strerror() is insecure in a multi-thread environment.
> This patch uses rte_strerror() to replace it.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>

Acked-by: Maryam Tahhan <mtahhan@redhat.com>

diff mbox series

Patch

diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 814398ba4b..0b561b6683 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -1191,7 +1191,7 @@  xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
 				&rxq->fq, &rxq->cq, &usr_config);
 		if (ret) {
 			AF_XDP_LOG_LINE(ERR, "Failed to create umem [%d]: [%s]",
-				   errno, strerror(errno));
+				   errno, rte_strerror(errno));
 			goto err;
 		}
 		umem->buffer = aligned_addr;
@@ -1408,7 +1408,7 @@  init_uds_sock(struct sockaddr_un *server, const char *dp_path)
 	if (connect(sock, (struct sockaddr *)server, sizeof(struct sockaddr_un)) < 0) {
 		close(sock);
 		AF_XDP_LOG_LINE(ERR, "Error connecting stream socket errno = [%d]: [%s]",
-			   errno, strerror(errno));
+			   errno, rte_strerror(errno));
 		return -1;
 	}
 
@@ -1492,7 +1492,7 @@  read_msg(int sock, char *response, struct sockaddr_un *s, int *fd)
 		return 0;
 
 	if (msglen < 0) {
-		AF_XDP_LOG_LINE(ERR, "recvmsg failed, %s", strerror(errno));
+		AF_XDP_LOG_LINE(ERR, "recvmsg failed, %s", rte_strerror(errno));
 		return -1;
 	}
 
@@ -1527,7 +1527,7 @@  make_request_dp(int sock, struct sockaddr_un *server, char *request,
 		rval = send_msg(sock, request, req_fd, dp_path);
 
 	if (rval < 0) {
-		AF_XDP_LOG_LINE(ERR, "Write error %s", strerror(errno));
+		AF_XDP_LOG_LINE(ERR, "Write error %s", rte_strerror(errno));
 		return -1;
 	}
 
@@ -2023,7 +2023,7 @@  parse_prog_arg(const char *key __rte_unused,
 
 	if (access(value, F_OK) != 0) {
 		AF_XDP_LOG_LINE(ERR, "Error accessing %s: %s",
-			   value, strerror(errno));
+			   value, rte_strerror(errno));
 		return -EINVAL;
 	}
 
@@ -2518,7 +2518,7 @@  rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
 		ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds);
 		if (ret < 0 && rte_errno != ENOTSUP) {
 			AF_XDP_LOG_LINE(ERR, "%s: Failed to register multi-process IPC callback: %s",
-				   name, strerror(rte_errno));
+				   name, rte_strerror(rte_errno));
 			return -1;
 		}
 	}