diff mbox series

[v4,19/42] dma/idxd: use rte strerror

Message ID	20241023082852.2780488-20-huangdengdui@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Thomas Monjalon
Headers	From: Dengdui Huang <huangdengdui@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>, <mb@smartsharesystems.com>, <david.marchand@redhat.com>, <iboukris@gmail.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <haijie1@huawei.com>, <liuyonglong@huawei.com> Subject: [PATCH v4 19/42] dma/idxd: use rte strerror Date: Wed, 23 Oct 2024 16:28:29 +0800 Message-ID: <20241023082852.2780488-20-huangdengdui@huawei.com> In-Reply-To: <20241023082852.2780488-1-huangdengdui@huawei.com> References: <20231114082539.1858594-44-huangdengdui@huawei.com> <20241023082852.2780488-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace strerror \| [v4,00/42] replace strerror [v4,01/42] devtools: forbid use of strerror [v4,02/42] eal: use rte strerror [v4,03/42] eventdev: use rte strerror [v4,04/42] latency: use rte strerror [v4,05/42] node: use rte strerror [v4,06/42] pdump: use rte strerror [v4,07/42] power: use rte strerror [v4,08/42] vhost: use rte strerror [v4,09/42] bpf: use rte strerror [v4,10/42] bus/cdx: use rte strerror [v4,11/42] bus/dpaa: use rte strerror [v4,12/42] bus/fslmc: use rte strerror [v4,13/42] bus/pci: use rte strerror [v4,14/42] bus/vdev: use rte strerror [v4,15/42] bus/vmbus: use rte strerror [v4,16/42] common/cnxk: use rte strerror [v4,17/42] common/mlx5: use rte strerror [v4,18/42] crypto/caam_jr: use rte strerror [v4,19/42] dma/idxd: use rte strerror [v4,20/42] net/af_packet: use rte strerror [v4,21/42] net/bnxt: use rte strerror [v4,22/42] net/af_xdp: use rte strerror [v4,23/42] net/bonding: use rte strerror [v4,24/42] net/dpaa: use rte strerror [v4,25/42] net/dpaa2: use rte strerror [v4,26/42] net/enetfec: use rte strerror [v4,27/42] net/failsafe: use rte strerror [v4,28/42] net/i40e: use rte strerror [v4,29/42] net/ice: use rte strerror [v4,30/42] net/ixgbe: use rte strerror [v4,31/42] net/memif: use rte strerror [v4,32/42] net/mlx4: use rte strerror [v4,33/42] net/mlx5: use rte strerror [v4,34/42] net/qede: use rte strerror [v4,35/42] net/sfc: use rte strerror [v4,36/42] net/tap: use rte strerror [v4,37/42] net/vhost: use rte strerror [v4,38/42] net/virtio: use rte strerror [v4,39/42] raw/ifpga: use rte strerror [v4,40/42] vdpa/ifc: use rte strerror [v4,41/42] vdpa/mlx5: use rte strerror [v4,42/42] vdpa/sfc: use rte strerror

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

huangdengdui Oct. 23, 2024, 8:28 a.m. UTC

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 drivers/dma/idxd/idxd_bus.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff mbox series

Patch

diff --git a/drivers/dma/idxd/idxd_bus.c b/drivers/dma/idxd/idxd_bus.c
index ba8076715d..c4a2c6bb54 100644
--- a/drivers/dma/idxd/idxd_bus.c
+++ b/drivers/dma/idxd/idxd_bus.c
@@ -16,6 +16,7 @@ 
 #include <rte_log.h>
 #include <rte_dmadev_pmd.h>
 #include <rte_string_fns.h>
+#include <rte_errno.h>
 
 #include "idxd_internal.h"
 
@@ -145,7 +146,7 @@  read_wq_string(struct rte_dsa_device *dev, const char *filename,
 	fd = open(sysfs_node, O_RDONLY);
 	if (fd < 0) {
 		IDXD_PMD_ERR("%s(): opening file '%s' failed: %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		return -1;
 	}
 
@@ -153,7 +154,7 @@  read_wq_string(struct rte_dsa_device *dev, const char *filename,
 	close(fd);
 	if (len < 0) {
 		IDXD_PMD_ERR("%s(): error reading file '%s': %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		return -1;
 	}
 	value[len] = '\0';
@@ -173,13 +174,13 @@  read_wq_int(struct rte_dsa_device *dev, const char *filename,
 	f = fopen(sysfs_node, "r");
 	if (f == NULL) {
 		IDXD_PMD_ERR("%s(): opening file '%s' failed: %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		return -1;
 	}
 
 	if (fscanf(f, "%d", value) != 1) {
 		IDXD_PMD_ERR("%s(): error reading file '%s': %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		ret = -1;
 	}
 
@@ -200,13 +201,13 @@  read_device_int(struct rte_dsa_device *dev, const char *filename,
 	f = fopen(sysfs_node, "r");
 	if (f == NULL) {
 		IDXD_PMD_ERR("%s(): opening file '%s' failed: %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		return -1;
 	}
 
 	if (fscanf(f, "%d", value) != 1) {
 		IDXD_PMD_ERR("%s(): error reading file '%s': %s",
-				__func__, sysfs_node, strerror(errno));
+				__func__, sysfs_node, rte_strerror(errno));
 		ret = -1;
 	}
 
@@ -323,7 +324,7 @@  dsa_scan(void)
 		if (errno == ENOENT)
 			return 0; /* no bus, return without error */
 		IDXD_PMD_ERR("%s(): opendir '%s' failed: %s",
-				__func__, path, strerror(errno));
+				__func__, path, rte_strerror(errno));
 		return -1;
 	}