diff mbox series

[v4,01/42] devtools: forbid use of strerror

Message ID	20241023082852.2780488-2-huangdengdui@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Thomas Monjalon
Headers	From: Dengdui Huang <huangdengdui@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>, <mb@smartsharesystems.com>, <david.marchand@redhat.com>, <iboukris@gmail.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <haijie1@huawei.com>, <liuyonglong@huawei.com> Subject: [PATCH v4 01/42] devtools: forbid use of strerror Date: Wed, 23 Oct 2024 16:28:11 +0800 Message-ID: <20241023082852.2780488-2-huangdengdui@huawei.com> In-Reply-To: <20241023082852.2780488-1-huangdengdui@huawei.com> References: <20231114082539.1858594-44-huangdengdui@huawei.com> <20241023082852.2780488-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace strerror \| [v4,00/42] replace strerror [v4,01/42] devtools: forbid use of strerror [v4,02/42] eal: use rte strerror [v4,03/42] eventdev: use rte strerror [v4,04/42] latency: use rte strerror [v4,05/42] node: use rte strerror [v4,06/42] pdump: use rte strerror [v4,07/42] power: use rte strerror [v4,08/42] vhost: use rte strerror [v4,09/42] bpf: use rte strerror [v4,10/42] bus/cdx: use rte strerror [v4,11/42] bus/dpaa: use rte strerror [v4,12/42] bus/fslmc: use rte strerror [v4,13/42] bus/pci: use rte strerror [v4,14/42] bus/vdev: use rte strerror [v4,15/42] bus/vmbus: use rte strerror [v4,16/42] common/cnxk: use rte strerror [v4,17/42] common/mlx5: use rte strerror [v4,18/42] crypto/caam_jr: use rte strerror [v4,19/42] dma/idxd: use rte strerror [v4,20/42] net/af_packet: use rte strerror [v4,21/42] net/bnxt: use rte strerror [v4,22/42] net/af_xdp: use rte strerror [v4,23/42] net/bonding: use rte strerror [v4,24/42] net/dpaa: use rte strerror [v4,25/42] net/dpaa2: use rte strerror [v4,26/42] net/enetfec: use rte strerror [v4,27/42] net/failsafe: use rte strerror [v4,28/42] net/i40e: use rte strerror [v4,29/42] net/ice: use rte strerror [v4,30/42] net/ixgbe: use rte strerror [v4,31/42] net/memif: use rte strerror [v4,32/42] net/mlx4: use rte strerror [v4,33/42] net/mlx5: use rte strerror [v4,34/42] net/qede: use rte strerror [v4,35/42] net/sfc: use rte strerror [v4,36/42] net/tap: use rte strerror [v4,37/42] net/vhost: use rte strerror [v4,38/42] net/virtio: use rte strerror [v4,39/42] raw/ifpga: use rte strerror [v4,40/42] vdpa/ifc: use rte strerror [v4,41/42] vdpa/mlx5: use rte strerror [v4,42/42] vdpa/sfc: use rte strerror

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

huangdengdui Oct. 23, 2024, 8:28 a.m. UTC

The function strerror() is insecure in a multi-thread environment.
rte_strerror() has been provided in DPDK to replace it.

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 devtools/checkpatches.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff mbox series

Patch

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index d860f19045..078d5714da 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -209,6 +209,14 @@  check_forbidden_additions() { # <patch>
 		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
 		"$1" || res=1
 
+	# refrain from using strerror() for drivers and libs
+	awk -v FOLDERS="lib drivers" \
+		-v EXPRESSIONS="\\\sstrerror\\\(" \
+		-v RET_ON_FAIL=1 \
+		-v MESSAGE='Using strerror, prefer rte_strerror' \
+		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+		"$1" || res=1
+
 	# refrain from using RTE_LOG_REGISTER for drivers and libs
 	awk -v FOLDERS='lib drivers' \
 		-v EXPRESSIONS='\\<RTE_LOG_REGISTER\\>' \